Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10808074: Set --enable-touch-event by default on Win7+ (Closed)

Created:
8 years, 5 months ago by girard
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Set --enable-touch-event by default on Win7+ BUG=138195 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148838

Patch Set 1 #

Patch Set 2 : Adding test to ensure that a touch device is present before enabling touch events. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
girard
Adds the --enable-touch-events flag in Win7+ This is a repeat of https://chromiumcodereview.appspot.com/10583007/ which was reverted ...
8 years, 5 months ago (2012-07-23 13:52:21 UTC) #1
cpu_(ooo_6.6-7.5)
I'll go with whatever iyengar thinks of this.
8 years, 5 months ago (2012-07-23 19:23:33 UTC) #2
girard
Updated as per Iyengar's suggestion. We now only add the flag if a touch device ...
8 years, 5 months ago (2012-07-23 19:46:13 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
8 years, 5 months ago (2012-07-25 19:59:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10808074/2002
8 years, 5 months ago (2012-07-26 12:37:08 UTC) #5
commit-bot: I haz the power
Presubmit check for 10808074-2002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-26 12:37:12 UTC) #6
girard
Ooops. Need an owner.
8 years, 4 months ago (2012-07-27 15:25:11 UTC) #7
girard
Again, oops. Need an owner who's not out of office. Sorry for the spam.
8 years, 4 months ago (2012-07-27 18:41:43 UTC) #8
darin (slow to review)
LGTM
8 years, 4 months ago (2012-07-27 19:23:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10808074/2002
8 years, 4 months ago (2012-07-27 19:33:37 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 22:43:29 UTC) #11
Change committed as 148838

Powered by Google App Engine
This is Rietveld 408576698