Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 10808071: Set CaptureClient instance for aura_demo and aura_bench (Closed)

Created:
8 years, 5 months ago by Hongbo Min
Modified:
8 years, 5 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Set CaptureClient instance for aura_demo and aura_bench BUG=138400 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148083

Patch Set 1 #

Patch Set 2 : set capture client for aura_demo and aura_bench #

Total comments: 1

Patch Set 3 : Correct code style #

Patch Set 4 : Update their DEPS files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/aura/bench/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A ui/aura/demo/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Hongbo Min
Set the CaptureClient property for root window, otherwise, the client::GetCaptureClient returns null and cause null ...
8 years, 5 months ago (2012-07-21 14:15:16 UTC) #1
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10808071/diff/3001/ui/aura/demo/demo_main.cc File ui/aura/demo/demo_main.cc (right): http://codereview.chromium.org/10808071/diff/3001/ui/aura/demo/demo_main.cc#newcode103 ui/aura/demo/demo_main.cc:103: new aura::shared::RootWindowCaptureClient(root_window_)); 4-space indent
8 years, 5 months ago (2012-07-23 17:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10808071/2004
8 years, 5 months ago (2012-07-24 03:15:13 UTC) #3
Hongbo Min
On 2012/07/23 17:19:49, Ben Goodger (Google) wrote: > lgtm > > http://codereview.chromium.org/10808071/diff/3001/ui/aura/demo/demo_main.cc > File ui/aura/demo/demo_main.cc ...
8 years, 5 months ago (2012-07-24 03:15:13 UTC) #4
commit-bot: I haz the power
Try job failure for 10808071-2004 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 5 months ago (2012-07-24 04:28:57 UTC) #5
Hongbo Min
On 2012/07/24 04:28:57, I haz the power (commit-bot) wrote: > Try job failure for 10808071-2004 ...
8 years, 5 months ago (2012-07-24 05:12:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10808071/3002
8 years, 5 months ago (2012-07-24 05:49:04 UTC) #7
commit-bot: I haz the power
Try job failure for 10808071-3002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-24 07:13:50 UTC) #8
Hongbo Min
On 2012/07/24 07:13:50, I haz the power (commit-bot) wrote: > Try job failure for 10808071-3002 ...
8 years, 5 months ago (2012-07-24 07:25:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10808071/3002
8 years, 5 months ago (2012-07-24 09:53:13 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 11:23:23 UTC) #11
Change committed as 148083

Powered by Google App Engine
This is Rietveld 408576698