Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 10808069: Remove old test timeout and process waiting function interfaces. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove old test timeout and process waiting function interfaces. BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148656

Patch Set 1 #

Patch Set 2 : Remove old test timeout and wait for process interfaces. #

Total comments: 2

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -83 lines) Patch
M base/process_util.h View 3 chunks +0 lines, -9 lines 0 comments Download
M base/process_util_posix.cc View 5 chunks +4 lines, -22 lines 0 comments Download
M base/process_util_win.cc View 1 2 6 chunks +9 lines, -25 lines 0 comments Download
M base/test/test_timeouts.h View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted Vessenes
I believe this patch is now ready to go, assuming the try bots come back ...
8 years, 5 months ago (2012-07-25 04:08:53 UTC) #1
jar (doing other things)
https://chromiumcodereview.appspot.com/10808069/diff/6001/base/process_util_win.cc File base/process_util_win.cc (right): https://chromiumcodereview.appspot.com/10808069/diff/6001/base/process_util_win.cc#newcode592 base/process_util_win.cc:592: bool WaitForProcessesToExit(const FilePath::StringType& executable_name, Who is calling this now? ...
8 years, 5 months ago (2012-07-25 19:03:18 UTC) #2
Ted Vessenes
I missed the additional WaitForProcessesToExit() interface in this patch, so I cleaned it out and ...
8 years, 5 months ago (2012-07-26 00:12:43 UTC) #3
jar (doing other things)
lgtm
8 years, 5 months ago (2012-07-26 00:39:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10808069/12001
8 years, 5 months ago (2012-07-26 03:16:54 UTC) #5
commit-bot: I haz the power
Try job failure for 10808069-12001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 04:06:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10808069/12001
8 years, 5 months ago (2012-07-26 19:09:50 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 23:41:42 UTC) #8
Change committed as 148656

Powered by Google App Engine
This is Rietveld 408576698