Issue 10808068: Store ChromeToMobile device list and timestamp prefs.

Issue 10808068: Store ChromeToMobile device list and timestamp prefs. (Closed)

Created:
8 years, 5 months ago by msw

Modified:
8 years, 5 months ago

Reviewers:
Elliot Glaysher, sail, sky

CC:
chromium-reviews, nyquist

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Store ChromeToMobile device list and timestamp prefs. Store profile prefs and deprecate service-local storage. (in preparation for new Sync Invalidation API integration) Add kChromeToMobile[DeviceList|Timestamp] pref strings. Add RegisterUserPrefs() static method and standard call. Update/rename GetMobiles() and rename HasMobiles(). Update Mac unit test; misc minor cleanup and refactoring. BUG=102709 TEST=Updated unit test; no Chrome To Mobile regressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147981

Patch Set 1 : More progress. #

Patch Set 2 : Just store mobiles in prefs; rename HasMobiles and GetMobiles; etc. #

Total comments: 2

Patch Set 3 : Add GetMobiles ownership/lifetime comment. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -64 lines)			Patch
M	chrome/browser/chrome_to_mobile_service.h	View	1 2	4 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/chrome_to_mobile_service.cc	View	1	8 chunks	+33 lines, -11 lines	0 comments	Download
M	chrome/browser/chrome_to_mobile_service_factory.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	1	4 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm	View	1	3 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller_unittest.mm	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc	View	1	5 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc	View	1	7 chunks	+13 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

msw

Hey guys, please take a look; thanks! Sky: Service, Views bubble, chrome/common/pref_names.* Sail: Cocoa bubble ...

8 years, 5 months ago (2012-07-23 19:34:41 UTC) #1

sky

LGTM https://chromiumcodereview.appspot.com/10808068/diff/9002/chrome/browser/chrome_to_mobile_service.h File chrome/browser/chrome_to_mobile_service.h (right): https://chromiumcodereview.appspot.com/10808068/diff/9002/chrome/browser/chrome_to_mobile_service.h#newcode113 chrome/browser/chrome_to_mobile_service.h:113: virtual const base::ListValue* GetMobiles() const; Document ownership and ...

8 years, 5 months ago (2012-07-23 21:25:45 UTC) #4

msw

Done; landing. Thanks! https://chromiumcodereview.appspot.com/10808068/diff/9002/chrome/browser/chrome_to_mobile_service.h File chrome/browser/chrome_to_mobile_service.h (right): https://chromiumcodereview.appspot.com/10808068/diff/9002/chrome/browser/chrome_to_mobile_service.h#newcode113 chrome/browser/chrome_to_mobile_service.h:113: virtual const base::ListValue* GetMobiles() const; On ...

8 years, 5 months ago (2012-07-23 21:43:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10808068/1009

8 years, 5 months ago (2012-07-23 21:44:24 UTC) #6

Change committed as 147981

Expand Messages | Collapse Messages