Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10808065: Extensions Docs Server: TDS fix, no local caching (Closed)

Created:
8 years, 5 months ago by cduvall
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, clintstaley, chebert
Visibility:
Public.

Description

Extensions Docs Server: TDS fix, no local caching Some minor fixes that were bugging me: - TemplateDataSource now uses the correct path and does not depend on catching an exception - LocalFileSystem was caching files forever with the new FileSystem interface, now it doesn't - Added some logs for exception handling. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147985

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/appengine_url_fetcher.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/echo_handler.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/local_file_system.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/memcache_file_system_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 10 chunks +25 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source_test.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cduvall
8 years, 5 months ago (2012-07-20 22:19:00 UTC) #1
not at google - send to devlin
https://chromiumcodereview.appspot.com/10808065/diff/1/chrome/common/extensions/docs/server2/local_file_system.py File chrome/common/extensions/docs/server2/local_file_system.py (right): https://chromiumcodereview.appspot.com/10808065/diff/1/chrome/common/extensions/docs/server2/local_file_system.py#newcode48 chrome/common/extensions/docs/server2/local_file_system.py:48: return self.StatInfo(self._version) I don't understand this inc_version stuff. This ...
8 years, 5 months ago (2012-07-23 13:13:27 UTC) #2
cduvall
http://codereview.chromium.org/10808065/diff/1/chrome/common/extensions/docs/server2/local_file_system.py File chrome/common/extensions/docs/server2/local_file_system.py (right): http://codereview.chromium.org/10808065/diff/1/chrome/common/extensions/docs/server2/local_file_system.py#newcode48 chrome/common/extensions/docs/server2/local_file_system.py:48: return self.StatInfo(self._version) On 2012/07/23 13:13:27, kalman wrote: > I ...
8 years, 5 months ago (2012-07-23 19:04:41 UTC) #3
not at google - send to devlin
8 years, 5 months ago (2012-07-23 23:19:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698