Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: vm/dart_api_impl.cc

Issue 10808064: Rename some of the enum definitions inside classes to avoid conflict with the ObjectKind enum. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/compiler_test.cc ('k') | vm/dart_entry_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 9791)
+++ vm/dart_api_impl.cc (working copy)
@@ -2731,7 +2731,7 @@
if (!func.IsNull()) {
// We only provide access to a subset of function kinds.
RawFunction::Kind func_kind = func.kind();
- ASSERT(func_kind == RawFunction::kFunction ||
+ ASSERT(func_kind == RawFunction::kRegularFunction ||
func_kind == RawFunction::kGetterFunction ||
func_kind == RawFunction::kSetterFunction ||
func_kind == RawFunction::kConstructor ||
@@ -3791,8 +3791,8 @@
const String& source,
RawScript::Kind kind,
Dart_Handle* result) {
- bool update_lib_status = (kind == RawScript::kScript ||
- kind == RawScript::kLibrary);
+ bool update_lib_status = (kind == RawScript::kScriptTag ||
+ kind == RawScript::kLibraryTag);
if (update_lib_status) {
lib.SetLoadInProgress();
}
@@ -3843,7 +3843,7 @@
library,
url_str,
source_str,
- RawScript::kScript,
+ RawScript::kScriptTag,
&result);
return result;
}
@@ -4044,7 +4044,7 @@
library,
url_str,
source_str,
- RawScript::kLibrary,
+ RawScript::kLibraryTag,
&result);
// Propagate the error out right now.
if (::Dart_IsError(result)) {
@@ -4099,7 +4099,8 @@
RETURN_TYPE_ERROR(isolate, source, String);
}
Dart_Handle result;
- CompileSource(isolate, lib, url_str, source_str, RawScript::kSource, &result);
+ CompileSource(isolate, lib, url_str, source_str,
+ RawScript::kSourceTag, &result);
return result;
}
« no previous file with comments | « vm/compiler_test.cc ('k') | vm/dart_entry_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698