Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 10808061: [cros] Flip enable-new-oobe switch. (Closed)

Created:
8 years, 5 months ago by Nikita (slow)
Modified:
8 years, 5 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Flip enable-new-oobe switch. BUG=129799 TEST=Manual + autotests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148061

Patch Set 1 #

Patch Set 2 : fix tests - don't wait for wallpaper when zero delay is set #

Patch Set 3 : merge #

Patch Set 4 : leak RB on shutdown #

Patch Set 5 : don't load real wallpaper for tests that try to use that #

Patch Set 6 : move SetZeroDelays() call to SetUp() #

Patch Set 7 : revert test change\ #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -23 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
8 years, 5 months ago (2012-07-20 21:00:04 UTC) #1
Ivan Korotkov
lgtm
8 years, 5 months ago (2012-07-21 21:32:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10808061/18
8 years, 5 months ago (2012-07-24 05:19:01 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 08:21:45 UTC) #4
Change committed as 148061

Powered by Google App Engine
This is Rietveld 408576698