Issue 10808051: Unmirrors new tab button theme background in Rtl mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10808051: Unmirrors new tab button theme background in Rtl mode (Closed)

Created:
8 years, 5 months ago by pkotwicz

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unmirrors new tab button theme background in Rtl mode. When running Chrome in RTL mode, the new tab button is mirrored, but the theme background shouldn't be. Bug=None Test=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150363

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View	1 2	1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10808051/4001

8 years, 4 months ago (2012-08-05 19:44:47 UTC) #3

commit-bot: I haz the power

Try job failure for 10808051-4001 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...

8 years, 4 months ago (2012-08-05 21:38:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10808051/4001

8 years, 4 months ago (2012-08-07 16:09:55 UTC) #5

Change committed as 150363

Expand Messages | Collapse Messages