Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 10808048: Revert r144460 "Remove the linux-only CR_SOURCE_ROOT environment variable override of base::DIR_SOU… (Closed)

Created:
8 years, 5 months ago by M-A Ruel
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, piman
Visibility:
Public.

Description

Revert r144460 "Remove the linux-only CR_SOURCE_ROOT environment variable override of base::DIR_SOURCE_ROOT." CR_SOURCE_ROOT is used in practice by linux user(s), plural still to be determined, mostly for ChromeOS related development. R=willchan@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148621

Patch Set 1 #

Patch Set 2 : Better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M base/base_paths_posix.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M testing/test_env.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
It's been a few months I told Antoine I'd revert the CL but I dragged ...
8 years, 5 months ago (2012-07-20 14:22:35 UTC) #1
M-A Ruel
On 2012/07/20 14:22:35, Marc-Antoine Ruel wrote: > It's been a few months I told Antoine ...
8 years, 5 months ago (2012-07-26 13:18:21 UTC) #2
piman
LGTM, thanks. I wonder if there could be a way through the build system to ...
8 years, 5 months ago (2012-07-26 17:07:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10808048/2001
8 years, 5 months ago (2012-07-26 18:05:21 UTC) #4
commit-bot: I haz the power
Presubmit check for 10808048-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-26 18:05:26 UTC) #5
willchan no longer on Chromium
lgtm
8 years, 5 months ago (2012-07-26 18:30:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10808048/2001
8 years, 5 months ago (2012-07-26 18:32:11 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 20:53:57 UTC) #8
Change committed as 148621

Powered by Google App Engine
This is Rietveld 408576698