Issue 10808041: On desktop GL, don't disable vertex attribute 0 when restoring state, or nothing will be drawn duri…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10808041: On desktop GL, don't disable vertex attribute 0 when restoring state, or nothing will be drawn duri… (Closed)

Created:
8 years, 5 months ago by Ken Russell (switch to Gerrit)

Modified:
8 years, 5 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium, Jeff Timanus

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

On desktop GL, don't disable vertex attribute 0 when restoring state, or nothing will be drawn during subsequent draw calls. BUG=138088 TEST=gpu_unittests; revised WebGL conformance test gl-vertex-attrib-zero-issues.html (will be pulled to GPU bots); test cases from bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147584

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/10808041/1

8 years, 5 months ago (2012-07-19 23:30:43 UTC) #3

Change committed as 147584

Expand Messages | Collapse Messages