[Sync] Avoid ObserverListThreadSafe in ChromeSyncNotificationBridge

[Sync] Avoid ObserverListThreadSafe in ChromeSyncNotificationBridge

Instead just use an inner ref-counted class, and assume the bridge
will be used only on the UI and sync thread.

This is to make refactoring the sync-specific parts out of
SyncNotifier{,Observer} easier.

BUG=124149
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147717

[akalin, 2012-07-19 22:48:32]

+zea for review
+dcheng FYI

[akalin, 2012-07-20 18:33:06]

Fixed integration test failures.

[Nicolas Zea, 2012-07-20 20:01:36]

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
File chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc
(right):

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc:104: :
ui_thread_(BrowserThread::UI, &ui_loop_),
are ui thread and ui loop both still needed? I don't think you post tasks to the
UI thread anymore, so you just need to ensure the "on UI thread" dcheck's pass
right?

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc:147:
base::Unretained(this))));
does this need a BlockForSyncThread after it? I suppose the sync_thread_.Stop()
in Teardown might take care of it, but I think it makes sense to have one here
anyways.

[akalin, 2012-07-20 20:19:54]

PTAL

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
File chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc
(right):

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc:104: :
ui_thread_(BrowserThread::UI, &ui_loop_),
On 2012/07/20 20:01:37, nzea wrote:
> are ui thread and ui loop both still needed? I don't think you post tasks to
the
> UI thread anymore, so you just need to ensure the "on UI thread" dcheck's pass
> right?

Removed ui_loop_.  Also made all the member variables private.

http://codereview.chromium.org/10808040/diff/6001/chrome/browser/sync/glue/ch...
chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc:147:
base::Unretained(this))));
On 2012/07/20 20:01:37, nzea wrote:
> does this need a BlockForSyncThread after it? I suppose the
sync_thread_.Stop()
> in Teardown might take care of it, but I think it makes sense to have one here
> anyways.

Done.

[Nicolas Zea, 2012-07-20 20:32:49]

LGTM

[commit-bot: I haz the power, 2012-07-20 20:34:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10808040/6002