Update #if guards in base/ that control whether to use stat or stat64 (and friends).

Update #if guards in base/ that control whether to use stat or stat64 (and friends).

Mac SDKs earlier than 10.5 did not define fstat64. The 10.5 SDK defined both
fstat and fstat64. And in the 10.6 SDK, fstat64 is deprecated and the right
implementation is selected at runtime.

This makes the use of fstat unconditional on OS_MACOSX now that the build SDK
is 10.6.

BUG=137676
TEST=compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147554

[Mark Mentovai, 2012-07-19 20:38:41]

Same comment in both files.

https://chromiumcodereview.appspot.com/10808037/diff/1/base/file_util_posix.cc
File base/file_util_posix.cc (right):

https://chromiumcodereview.appspot.com/10808037/diff/1/base/file_util_posix.c...
base/file_util_posix.cc:61: #if defined(OS_BSD) || defined(OS_IOS) ||
defined(OS_MACOSX)
Doesn’t OS_IOS imply OS_MACOSX? You should be able to just check OS_MACOSX.

[Robert Sesek, 2012-07-19 20:43:01]

https://chromiumcodereview.appspot.com/10808037/diff/1/base/file_util_posix.cc
File base/file_util_posix.cc (right):

https://chromiumcodereview.appspot.com/10808037/diff/1/base/file_util_posix.c...
base/file_util_posix.cc:61: #if defined(OS_BSD) || defined(OS_IOS) ||
defined(OS_MACOSX)
On 2012/07/19 20:38:41, Mark Mentovai wrote:
> Doesn’t OS_IOS imply OS_MACOSX? You should be able to just check OS_MACOSX.

Yes, it does. base/build_config.h:

#if defined(__APPLE__)
#define OS_MACOSX 1
#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
#define OS_IOS 1
#endif  // defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
#elif
...

[Mark Mentovai, 2012-07-19 20:47:53]

LGTM

[commit-bot: I haz the power, 2012-07-19 20:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10808037/3002

[commit-bot: I haz the power, 2012-07-19 22:24:04]

Change committed as 147554