runtime/vm/debugger.h - Issue 10808032: Proper implementation of Dart_GetStackTrace. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1440)

My Issues | Starred Open | Closed | All

Unified Diff: runtime/vm/debugger.h

Issue 10808032: Proper implementation of Dart_GetStackTrace. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/vm/debugger.h

diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h

index 4c67412a975bbffb79b2e3394a7bbb65e3e349de..ab16c481d118a8951dea43066acd24663bd9d76b 100644

--- a/runtime/vm/debugger.h

+++ b/runtime/vm/debugger.h

@@ -259,6 +259,7 @@ class Debugger {

void BreakpointCallback();

DebuggerStackTrace* StackTrace() const { return stack_trace_; }

+ DebuggerStackTrace* CollectStackTrace();

RawArray* GetInstanceFields(const Instance& obj);

RawArray* GetStaticFields(const Class& cls);

@@ -309,7 +310,6 @@ class Debugger {

void SyncBreakpoint(SourceBreakpoint* bpt);

- DebuggerStackTrace* CollectStackTrace();

void SignalBpResolved(SourceBreakpoint *bpt);

bool IsDebuggable(const Function& func);

« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698