Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10808022: Add unit_tests bundle as a default compile target for Android. (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add unit_tests bundle as a default compile target for Android. Since With this change we will start compiling unit_tests_apk on the main waterfall, we are making android a default try bot. To be submitted after we have increased our capacity to handle the extra load. BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -4 lines 0 comments Download
M build/all_android.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nilesh
8 years, 5 months ago (2012-07-18 22:05:33 UTC) #1
John Grabowski
Like, and am proud of you guys (sniff), but don't want to ell gee tee ...
8 years, 5 months ago (2012-07-18 22:32:48 UTC) #2
Isaac (away)
capacity live, lgtm but need rubberstamp
8 years, 5 months ago (2012-07-19 14:24:05 UTC) #3
Isaac (away)
Oh, this is a bigger increase than I expected. By changing PRESUBMIT.py you're also increasing ...
8 years, 5 months ago (2012-07-19 14:28:33 UTC) #4
Isaac (away)
nevermind, ignore the thing about +65%. PRESUBMIT.py only affects git try, was thinking the change ...
8 years, 5 months ago (2012-07-19 14:39:44 UTC) #5
M-A Ruel
lgtm
8 years, 5 months ago (2012-07-19 15:06:13 UTC) #6
nilesh
On 2012/07/19 15:06:13, Marc-Antoine Ruel wrote: > lgtm Going for it.
8 years, 5 months ago (2012-07-19 15:20:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10808022/1
8 years, 5 months ago (2012-07-19 15:20:21 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 16:30:33 UTC) #9
Change committed as 147453

Powered by Google App Engine
This is Rietveld 408576698