Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6766)

Unified Diff: chrome/browser/printing/print_job_manager.h

Issue 10808006: Move printing.* prefs from local state to profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased just in case as the CL is a few days old now plus I got my branches all mixed up a bit. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/printing/print_job_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_manager.h
diff --git a/chrome/browser/printing/print_job_manager.h b/chrome/browser/printing/print_job_manager.h
index b73f972968b993a3a046fd32a2bc4020aab81e64..f25764e44d5a7b22f1b39057d8d246d5becaaecb 100644
--- a/chrome/browser/printing/print_job_manager.h
+++ b/chrome/browser/printing/print_job_manager.h
@@ -9,13 +9,10 @@
#include "base/memory/ref_counted.h"
#include "base/synchronization/lock.h"
-#include "chrome/browser/prefs/pref_member.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "printing/print_destination_interface.h"
-class PrefService;
-
namespace printing {
class JobEventDetails;
@@ -27,10 +24,6 @@ class PrintJobManager : public content::NotificationObserver {
PrintJobManager();
virtual ~PrintJobManager();
- // Registers for changes to the printing enabled preference in |prefs|.
- // This method should be called on the UI thread.
- void InitOnUIThread(PrefService* prefs);
-
// On browser quit, we should wait to have the print job finished.
void OnQuit();
@@ -50,17 +43,11 @@ class PrintJobManager : public content::NotificationObserver {
// called from any thread. Current use case is poping from the browser thread.
void PopPrinterQuery(int document_cookie, scoped_refptr<PrinterQuery>* job);
- static void RegisterPrefs(PrefService* prefs);
-
// content::NotificationObserver
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // Only accessed on the IO thread. UI thread can query
- // prefs::kPrintingEnabled via g_browser_process->local_state() directly.
- bool printing_enabled() const;
-
// May return NULL when no destination was set.
PrintDestinationInterface* destination() const { return destination_.get(); }
@@ -74,16 +61,6 @@ class PrintJobManager : public content::NotificationObserver {
content::NotificationRegistrar registrar_;
- // Printing is enabled/disabled. For printing with the native print dialog,
- // this variable is checked at only one place, by
- // PrintingMessageFilter::OnGetDefaultPrintSettings. If its value is true
- // at that point, then the initiated print flow will complete itself,
- // even if the value of this variable changes afterwards.
- // In the print preview workflow, this variable is checked in
- // PrintingMessageFilter::OnUpdatePrintSettings, which gets called multiple
- // times in the print preview workflow.
- BooleanPrefMember printing_enabled_;
-
// Used to serialize access to queued_workers_.
base::Lock lock_;
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/printing/print_job_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698