Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: chrome/browser/printing/print_preview_tab_controller_unittest.cc

Issue 10808006: Move printing.* prefs from local state to profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased just in case as the CL is a few days old now plus I got my branches all mixed up a bit. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_service.h"
5 #include "chrome/browser/printing/print_preview_tab_controller.h" 6 #include "chrome/browser/printing/print_preview_tab_controller.h"
6 #include "chrome/browser/printing/print_preview_unit_test_base.h"
7 #include "chrome/browser/printing/print_view_manager.h" 7 #include "chrome/browser/printing/print_view_manager.h"
8 #include "chrome/browser/ui/browser_commands.h" 8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/browser_list.h" 9 #include "chrome/browser/ui/browser_list.h"
10 #include "chrome/browser/ui/browser_tabstrip.h" 10 #include "chrome/browser/ui/browser_tabstrip.h"
11 #include "chrome/browser/ui/tab_contents/tab_contents.h" 11 #include "chrome/browser/ui/tab_contents/tab_contents.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h" 12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
13 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h" 13 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
14 #include "chrome/common/pref_names.h"
15 #include "chrome/test/base/browser_with_test_window_test.h"
14 #include "content/public/browser/navigation_details.h" 16 #include "content/public/browser/navigation_details.h"
15 #include "content/public/browser/notification_service.h" 17 #include "content/public/browser/notification_service.h"
16 #include "content/public/browser/notification_types.h" 18 #include "content/public/browser/notification_types.h"
17 #include "content/public/common/url_constants.h" 19 #include "content/public/common/url_constants.h"
18 20
19 // Test crashes on Aura due to initiator tab's native view having no parent. 21 // Test crashes on Aura due to initiator tab's native view having no parent.
20 // http://crbug.com/104284 22 // http://crbug.com/104284
21 #if defined(USE_AURA) 23 #if defined(USE_AURA)
22 #define MAYBE_GetOrCreatePreviewTab DISABLED_GetOrCreatePreviewTab 24 #define MAYBE_GetOrCreatePreviewTab DISABLED_GetOrCreatePreviewTab
23 #define MAYBE_MultiplePreviewTabs DISABLED_MultiplePreviewTabs 25 #define MAYBE_MultiplePreviewTabs DISABLED_MultiplePreviewTabs
24 #define MAYBE_ClearInitiatorTabDetails DISABLED_ClearInitiatorTabDetails 26 #define MAYBE_ClearInitiatorTabDetails DISABLED_ClearInitiatorTabDetails
25 #else 27 #else
26 #define MAYBE_GetOrCreatePreviewTab GetOrCreatePreviewTab 28 #define MAYBE_GetOrCreatePreviewTab GetOrCreatePreviewTab
27 #define MAYBE_MultiplePreviewTabs MultiplePreviewTabs 29 #define MAYBE_MultiplePreviewTabs MultiplePreviewTabs
28 #define MAYBE_ClearInitiatorTabDetails ClearInitiatorTabDetails 30 #define MAYBE_ClearInitiatorTabDetails ClearInitiatorTabDetails
29 #endif 31 #endif
30 32
31 class PrintPreviewTabControllerUnitTest : public PrintPreviewUnitTestBase { 33 class PrintPreviewTabControllerUnitTest : public BrowserWithTestWindowTest {
32 public: 34 public:
33 PrintPreviewTabControllerUnitTest() {} 35 PrintPreviewTabControllerUnitTest() {}
34 virtual ~PrintPreviewTabControllerUnitTest() {} 36 virtual ~PrintPreviewTabControllerUnitTest() {}
37
38 protected:
39 virtual void SetUp() OVERRIDE {
40 BrowserWithTestWindowTest::SetUp();
41
42 profile()->GetPrefs()->SetBoolean(prefs::kPrintPreviewDisabled, false);
43 }
35 }; 44 };
36 45
37 // Create/Get a preview tab for initiator tab. 46 // Create/Get a preview tab for initiator tab.
38 TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) { 47 TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) {
39 // Lets start with one window with one tab. 48 // Lets start with one window with one tab.
40 EXPECT_EQ(1u, BrowserList::size()); 49 EXPECT_EQ(1u, BrowserList::size());
41 EXPECT_EQ(0, browser()->tab_count()); 50 EXPECT_EQ(0, browser()->tab_count());
42 chrome::NewTab(browser()); 51 chrome::NewTab(browser());
43 EXPECT_EQ(1, browser()->tab_count()); 52 EXPECT_EQ(1, browser()->tab_count());
44 53
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 tab_controller->EraseInitiatorTabInfo(preview_tab); 163 tab_controller->EraseInitiatorTabInfo(preview_tab);
155 164
156 // Get the print preview tab for initiator tab. 165 // Get the print preview tab for initiator tab.
157 TabContents* new_preview_tab = 166 TabContents* new_preview_tab =
158 tab_controller->GetOrCreatePreviewTab(initiator_tab); 167 tab_controller->GetOrCreatePreviewTab(initiator_tab);
159 168
160 // New preview tab is created. 169 // New preview tab is created.
161 EXPECT_EQ(1, browser()->tab_count()); 170 EXPECT_EQ(1, browser()->tab_count());
162 EXPECT_NE(new_preview_tab, preview_tab); 171 EXPECT_NE(new_preview_tab, preview_tab);
163 } 172 }
OLDNEW
« no previous file with comments | « chrome/browser/printing/print_job_manager.cc ('k') | chrome/browser/printing/print_preview_unit_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698