Bluetooth API: add discovering changed events

Bluetooth API: add discovering changed events

TEST=updated api test
BUG=138725
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149250

[bryeung, 2012-07-24 16:54:21]

Mike: do you have time to look at this one?  Thanks!

[miket_OOO, 2012-07-24 16:58:50]

LGTM. See one question below.

https://chromiumcodereview.appspot.com/10807087/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/bluetooth_event_router.cc (right):

https://chromiumcodereview.appspot.com/10807087/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/bluetooth_event_router.cc:88: DCHECK(adapter
== adapter_.get());
Sorry I'm late to this design party, but if this must be true, why have the
parameter in the signature at all?

[bryeung, 2012-07-24 17:02:09]

https://chromiumcodereview.appspot.com/10807087/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/bluetooth_event_router.cc (right):

https://chromiumcodereview.appspot.com/10807087/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/bluetooth_event_router.cc:88: DCHECK(adapter
== adapter_.get());
On 2012/07/24 16:58:50, miket wrote:
> Sorry I'm late to this design party, but if this must be true, why have the
> parameter in the signature at all?

It has to be in the signature because it's an override.

There are cases, in general, where the adapter might not be the same.  But the
extension system only deals with the default adapter, so it should be true for
us.

Thinking about this more, maybe it should be an early NOP return if the adapters
don't match?

[miket_OOO, 2012-07-24 17:05:31]

> Thinking about this more, maybe it should be an early NOP return if the
adapters
> don't match?

I don't know enough about the likelihood of a runtime mismatch, but yes, some
sort of check in release mode (CHECK or early return) seems prudent. Up to you
-- if a DCHECK is sure to catch all classes of errors, then OK as-is.

[bryeung, 2012-07-24 17:07:33]

Landing as-is.  Will address DCHECK comment in a follow-up CL.

[commit-bot: I haz the power, 2012-07-24 17:07:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10807087/1

[commit-bot: I haz the power, 2012-07-24 17:07:49]

Failed to apply patch for chrome/browser/extensions/extension_event_names.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/extension_event_names.cc
Hunk #1 FAILED at 60.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_event_names.cc.rej

[commit-bot: I haz the power, 2012-07-24 18:17:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10807087/9001

[commit-bot: I haz the power, 2012-07-24 19:37:35]

Try job failure for 10807087-9001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-24 19:47:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10807087/9001

[commit-bot: I haz the power, 2012-07-24 21:18:49]

Try job failure for 10807087-9001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-31 15:01:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10807087/15001

[commit-bot: I haz the power, 2012-07-31 15:02:00]

Presubmit check for 10807087-15001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.4s to calculate.

[commit-bot: I haz the power, 2012-07-31 18:08:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10807087/15003

[commit-bot: I haz the power, 2012-07-31 19:45:00]

Change committed as 149250