Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3625)

Unified Diff: chrome/browser/extensions/settings/managed_value_store_cache.h

Issue 10807086: Trigger chrome.storage.onChanged events for policy updates on the 'managed' namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased, addressed comments, fixed ManagedStorageDisabled test Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/settings/managed_value_store_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/settings/managed_value_store_cache.h
diff --git a/chrome/browser/extensions/settings/managed_value_store_cache.h b/chrome/browser/extensions/settings/managed_value_store_cache.h
index b59484f8b0cc151e2efd8129de3b571058d243ed..4507c7929e1d89449746d7cdfa1d7af85393314f 100644
--- a/chrome/browser/extensions/settings/managed_value_store_cache.h
+++ b/chrome/browser/extensions/settings/managed_value_store_cache.h
@@ -7,23 +7,26 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/extensions/settings/settings_observer.h"
#include "chrome/browser/extensions/settings/value_store_cache.h"
-
-namespace policy {
-class PolicyService;
-} // namespace policy
+#include "chrome/browser/policy/policy_service.h"
namespace extensions {
// Runs the StorageCallback with a read-only ValueStore that pulls values from
// the PolicyService for the given extension.
-class ManagedValueStoreCache : public ValueStoreCache {
+class ManagedValueStoreCache : public ValueStoreCache,
+ public policy::PolicyService::Observer {
public:
- explicit ManagedValueStoreCache(policy::PolicyService* policy_service);
+ ManagedValueStoreCache(policy::PolicyService* policy_service,
+ scoped_refptr<SettingsObserverList> observers);
virtual ~ManagedValueStoreCache();
// ValueStoreCache implementation:
+ virtual void ShutdownOnUI() OVERRIDE;
+
virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoop() const OVERRIDE;
virtual void RunWithValueStoreForExtension(
@@ -32,9 +35,18 @@ class ManagedValueStoreCache : public ValueStoreCache {
virtual void DeleteStorageSoon(const std::string& extension_id) OVERRIDE;
+ // PolicyService::Observer implementation:
+
+ virtual void OnPolicyUpdated(policy::PolicyDomain domain,
+ const std::string& component_id,
+ const policy::PolicyMap& previous,
+ const policy::PolicyMap& current) OVERRIDE;
+
private:
policy::PolicyService* policy_service_;
+ scoped_refptr<SettingsObserverList> observers_;
+
DISALLOW_COPY_AND_ASSIGN(ManagedValueStoreCache);
};
« no previous file with comments | « no previous file | chrome/browser/extensions/settings/managed_value_store_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698