Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10807083: Revert 148055 - Move CachedRanges out and add support for checksum. (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 5 months ago
Reviewers:
kaiwang
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 148055 - Move CachedRanges out and add support for checksum. This breaks the NaCL compiler, as the addition the base.gypi results in a too long command line. For the sake of getting the tree green, I'm reverting this, although the NaCL compiler is really to blame Review URL: https://chromiumcodereview.appspot.com/10796047 TBR=kaiwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -357 lines) Patch
M base/base.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/metrics/bucket_ranges.h View 1 chunk +0 lines, -69 lines 0 comments Download
D base/metrics/bucket_ranges.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D base/metrics/bucket_ranges_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M base/metrics/histogram.h View 11 chunks +52 lines, -16 lines 0 comments Download
M base/metrics/histogram.cc View 8 chunks +36 lines, -10 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 4 chunks +15 lines, -19 lines 0 comments Download
M base/metrics/statistics_recorder.h View 4 chunks +12 lines, -12 lines 0 comments Download
M base/metrics/statistics_recorder.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
8 years, 5 months ago (2012-07-24 08:20:15 UTC) #1
jochen (gone - plz use gerrit)
fyi
8 years, 5 months ago (2012-07-24 08:20:42 UTC) #2
Hironori Bono
Greetings Kai, Apologies for reverting your change. In brief, your change just unveiled a problem ...
8 years, 5 months ago (2012-07-24 09:24:00 UTC) #3
kaiwang
8 years, 5 months ago (2012-07-24 17:32:20 UTC) #4
No problem. I'll try to submit again after your fix.

On Tue, Jul 24, 2012 at 2:24 AM, <hbono@chromium.org> wrote:

> Greetings Kai,
>
> Apologies for reverting your change. In brief, your change just unveiled a
> problem of build_nexe.py on Windows (Bug 138697 <http://crbug.com/138687>)
> and
> your change does not do anything wrong. Currently, I'm writing a workaround
> change
<http://codereview.chromium.**org/10806082/<http://codereview.chromium.org/108...>
> so you can land your change
> without breaking Windows builds.
> Sorry for your inconveniences.
>
> Regards,
>
> Hironori Bono
>
>
https://chromiumcodereview.**appspot.com/10807083/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698