Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: vm/object_store.h

Issue 10807078: Address review comments from a previous CL. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/object.cc ('K') | « vm/object.cc ('k') | vm/object_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object_store.h
===================================================================
--- vm/object_store.h (revision 9828)
+++ vm/object_store.h (working copy)
@@ -19,8 +19,8 @@
// by snapshots eventually.
class ObjectStore {
public:
- // Index for objects/types/classes stored in the object store,
- // this index is used in snapshots to refer to classes or objects directly.
+ // Index for objects/types stored in the object store,
+ // this index is used in snapshots to refer to objects directly.
enum {
kTrueValue = Object::kMaxId,
kFalseValue,
@@ -36,44 +36,6 @@
kStringInterface,
kListInterface,
kByteArrayInterface,
- kObjectClass,
- kIntegerImplementationClass,
- kSmiClass,
- kMintClass,
- kBigintClass,
- kDoubleClass,
- kOneByteStringClass,
- kTwoByteStringClass,
- kFourByteStringClass,
- kExternalOneByteStringClass,
- kExternalTwoByteStringClass,
- kExternalFourByteStringClass,
- kBoolClass,
- kArrayClass,
- kImmutableArrayClass,
- kGrowableObjectArrayClass,
- kInt8ArrayClass,
- kUint8ArrayClass,
- kInt16ArrayClass,
- kUint16ArrayClass,
- kInt32ArrayClass,
- kUint32ArrayClass,
- kInt64ArrayClass,
- kUint64ArrayClass,
- kFloat32ArrayClass,
- kFloat64ArrayClass,
- kExternalInt8ArrayClass,
- kExternalUint8ArrayClass,
- kExternalInt16ArrayClass,
- kExternalUint16ArrayClass,
- kExternalInt32ArrayClass,
- kExternalUint32ArrayClass,
- kExternalInt64ArrayClass,
- kExternalUint64ArrayClass,
- kExternalFloat32ArrayClass,
- kExternalFloat64ArrayClass,
- kStacktraceClass,
- kJSRegExpClass,
kMaxId,
kInvalidIndex = -1,
};
@@ -508,7 +470,6 @@
void VisitObjectPointers(ObjectPointerVisitor* visitor);
RawClass* GetClass(int index);
- int GetClassIndex(const RawClass* raw_class);
RawType* GetType(int index);
int GetTypeIndex(const RawType* raw_type);
« vm/object.cc ('K') | « vm/object.cc ('k') | vm/object_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698