Various cleanups, adding tests.

runtime/vm/flow_graph_compiler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 1091 matching lines @@
   __ SmiUntag(temp);
   __ cvtsi2sd(result, temp);
   __ Bind(&done);
 }
 
 
 #undef __
 #define __ compiler_->assembler()->
 
 
-static Address ToAddress(Location loc) {
+static Address ToSpillAddress(Location loc) {
   ASSERT(loc.IsSpillSlot());
   const intptr_t offset =
       (ParsedFunction::kFirstLocalSlotIndex - loc.spill_index()) * kWordSize;
   return Address(EBP, offset);
 }
 
 
 void ParallelMoveResolver::EmitMove(int index) {
   MoveOperands* move = moves_[index];
   const Location source = move->src();
   const Location destination = move->dest();
 
   if (source.IsRegister()) {
     if (destination.IsRegister()) {
       __ movl(destination.reg(), source.reg());
     } else {
       ASSERT(destination.IsSpillSlot());
-      __ movl(ToAddress(destination), source.reg());
+      __ movl(ToSpillAddress(destination), source.reg());
     }
   } else if (source.IsSpillSlot()) {
     if (destination.IsRegister()) {
-      __ movl(destination.reg(), ToAddress(source));
+      __ movl(destination.reg(), ToSpillAddress(source));
     } else {
       ASSERT(destination.IsSpillSlot());
-      MoveMemoryToMemory(ToAddress(destination), ToAddress(source));
+      MoveMemoryToMemory(ToSpillAddress(destination), ToSpillAddress(source));
     }
   } else {
     ASSERT(source.IsConstant());
     if (destination.IsRegister()) {
       __ LoadObject(destination.reg(), source.constant());
     } else {
       ASSERT(destination.IsSpillSlot());
-      StoreObject(ToAddress(destination), source.constant());
+      StoreObject(ToSpillAddress(destination), source.constant());
     }
   }
 
   move->Eliminate();
 }
 
 
 void ParallelMoveResolver::EmitSwap(int index) {
   MoveOperands* move = moves_[index];
   const Location source = move->src();
   const Location destination = move->dest();
 
   if (source.IsRegister() && destination.IsRegister()) {
     __ xchgl(destination.reg(), source.reg());
   } else if (source.IsRegister() && destination.IsSpillSlot()) {
-    Exchange(source.reg(), ToAddress(destination));
+    Exchange(source.reg(), ToSpillAddress(destination));
   } else if (source.IsSpillSlot() && destination.IsRegister()) {
-    Exchange(destination.reg(), ToAddress(source));
+    Exchange(destination.reg(), ToSpillAddress(source));
   } else if (source.IsSpillSlot() && destination.IsSpillSlot()) {
-    Exchange(ToAddress(destination), ToAddress(source));
+    Exchange(ToSpillAddress(destination), ToSpillAddress(source));
   } else {
     UNREACHABLE();
   }
 
   // The swap of source and destination has executed a move from source to
   // destination.
   move->Eliminate();
 
   // Any unperformed (including pending) move with a source of either
   // this move's source or destination needs to have their source
@@ skipping 50 matching lines @@
   __ popl(ECX);
   __ popl(EAX);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32