Various cleanups, adding tests.

runtime/vm/assembler_x64_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 512 matching lines @@
 
 
 ASSEMBLER_TEST_GENERATE(Bitwise64, assembler) {
   Label error;
   __ movq(RAX, Immediate(42));
   __ pushq(RAX);
   __ xorq(RAX, Address(RSP, 0));
   __ popq(RCX);
   __ cmpq(RAX, Immediate(0));
   __ j(NOT_EQUAL, &error);
+  __ movq(RCX, Immediate(0xFF));
+  __ movq(RAX, Immediate(0x5));
+  __ xorq(RCX, RAX);
+  __ cmpq(RCX, Immediate(0xFF ^ 0x5));
+  __ j(NOT_EQUAL, &error);
+  __ pushq(Immediate(0xFF));
+  __ movq(RCX, Immediate(0x5));
+  __ xorq(Address(RSP, 0), RCX);
+  __ popq(RCX);
+  __ cmpq(RCX, Immediate(0xFF ^ 0x5));
+  __ j(NOT_EQUAL, &error);
   __ xorq(RCX, RCX);
   __ orq(RCX, Immediate(256));
   __ movq(RAX, Immediate(4));
   __ orq(RCX, RAX);
   __ movq(RAX, Immediate(0xfff0));
   __ andq(RCX, RAX);
   __ movq(RAX, Immediate(1));
   __ pushq(RAX);
   __ orq(RCX, Address(RSP, 0));
   __ popq(RAX);
@@ skipping 833 matching lines @@
 ASSEMBLER_TEST_GENERATE(TestObjectCompare, assembler) {
   ObjectStore* object_store = Isolate::Current()->object_store();
   const Object& obj = Object::ZoneHandle(object_store->smi_class());
   Label fail;
   __ LoadObject(RAX, obj);
   __ CompareObject(RAX, obj);
   __ j(NOT_EQUAL, &fail);
   __ LoadObject(RCX, obj);
   __ CompareObject(RCX, obj);
   __ j(NOT_EQUAL, &fail);
+  const Smi& smi = Smi::ZoneHandle(Smi::New(15));
+  __ LoadObject(RCX, smi);
+  __ CompareObject(RCX, smi);
+  __ j(NOT_EQUAL, &fail);
+  __ pushq(RAX);
+  __ StoreObject(Address(RSP, 0), obj);
+  __ popq(RCX);
+  __ CompareObject(RCX, obj);
+  __ j(NOT_EQUAL, &fail);
+  __ pushq(RAX);
+  __ StoreObject(Address(RSP, 0), smi);
+  __ popq(RCX);
+  __ CompareObject(RCX, smi);
+  __ j(NOT_EQUAL, &fail);
   __ movl(RAX, Immediate(1));  // OK
   __ ret();
   __ Bind(&fail);
   __ movl(RAX, Immediate(0));  // Fail.
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(TestObjectCompare, entry) {
   typedef bool (*TestObjectCompare)();
@@ skipping 278 matching lines @@
   EXPECT_EQ(0, res);
   res = reinterpret_cast<ExtractSignBits>(entry)(-1.0);
   EXPECT_EQ(1, res);
   res = reinterpret_cast<ExtractSignBits>(entry)(-0.0);
   EXPECT_EQ(1, res);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64