Issue 10807066: Add assertions to limit register count for VSTM and VLDM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10807066: Add assertions to limit register count for VSTM and VLDM. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add assertions to limit register count for VSTM and VLDM. R=svenpanne@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12166

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/arm/assembler-arm.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 5 months ago (2012-07-23 07:50:32 UTC) #2

LGTM, but I am not sure if this fixes the underlying problem in the bug report
(IIRC): We use vstm/vldm only in a very restricted way, namely saving/restoring
d8-d15 and d0-d15.

Expand Messages | Collapse Messages