Issue 10807065: ash: Remove obsolete display TODO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10807065: ash: Remove obsolete display TODO. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
oshima

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Remove obsolete display TODO. R=oshima@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148088

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	ash/display/display_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

8 years, 5 months ago (2012-07-22 10:00:02 UTC) #2

lgtm

On Sat, Jul 21, 2012 at 8:05 PM, <tfarina@chromium.org> wrote:

> Reviewers: oshima,
>
> Description:
> ash: Remove obsolete display TODO.
>
> R=oshima@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10807065/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ash/display/display_**controller.h
>
>
> Index: ash/display/display_**controller.h
> diff --git a/ash/display/display_**controller.h b/ash/display/display_**
> controller.h
> index 0eb021b001844025410e17e890b1cf**8721cadfd6..**
> aff1d93df6f63693eac0ee17e1c595**66467eae4c 100644
> --- a/ash/display/display_**controller.h
> +++ b/ash/display/display_**controller.h
> @@ -25,7 +25,6 @@ class RootWindowController;
>
>  // DisplayController owns and maintains RootWindows for each attached
>  // display, keeping them in sync with display configuration changes.
> -// TODO(oshima): Rename DisplayXXX to DisplayXXX.
>  class ASH_EXPORT DisplayController : public aura::DisplayObserver {
>   public:
>    // Layout options where the secondary display should be positioned.
>
>
>

Expand Messages | Collapse Messages