Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 10807064: Revert 147799 - landed without owners approval (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
glotov1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 147799 - landed without owners approval Prevent loading libffmpegsumo.so to python (autotests) process. This is needed for ASAN environment because libffmpegsumo.so, being built with ASAN support, fails to load to python process (which is not ASAN-ed currently). At the same time it loads file to chrome or to gtest processes (like content_unittests) because they do have ASAN runtime. FYI: Alternative approach (https://chromiumcodereview.appspot.com/10692190/) was skipped because it disallowed ASAN to test libffmpegsumo.so. BUG=chromium-os:32259 TESTS=unit Review URL: https://chromiumcodereview.appspot.com/10786038 TBR=glotov@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M content/test/content_test_suite.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M content/test/content_test_suite_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
8 years, 5 months ago (2012-07-21 22:10:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698