Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: sandbox/linux/sandbox_linux.gypi

Issue 10807059: Refactor the setuid sandbox client code to its own class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer's comments and other minor nits. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/zygote/zygote_main_linux.cc ('k') | sandbox/linux/suid/client/setuid_sandbox_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/sandbox_linux.gypi
diff --git a/sandbox/linux/sandbox_linux.gypi b/sandbox/linux/sandbox_linux.gypi
index 5286921d375b36b2c3fb0d90f1e35c51ee0da9aa..e124007784a2fb16a68c8ac013916930a3084cf1 100644
--- a/sandbox/linux/sandbox_linux.gypi
+++ b/sandbox/linux/sandbox_linux.gypi
@@ -11,6 +11,9 @@
{
'target_name': 'sandbox',
'type': 'none',
+ 'dependencies': [
+ 'suid_sandbox_client',
+ ],
'conditions': [
# Only compile in the seccomp mode 1 code for the flag combination
# where we support it.
@@ -38,6 +41,7 @@
],
'sources': [
'tests/unit_tests.cc',
+ 'suid/client/setuid_sandbox_client_unittest.cc',
],
'include_dirs': [
'../..',
@@ -71,11 +75,12 @@
'target_name': 'chrome_sandbox',
'type': 'executable',
'sources': [
+ 'suid/common/sandbox.h',
+ 'suid/common/suid_unsafe_environment_variables.h',
'suid/linux_util.c',
'suid/linux_util.h',
'suid/process_util.h',
'suid/process_util_linux.c',
- 'suid/sandbox.h',
'suid/sandbox.c',
],
'cflags': [
@@ -100,5 +105,22 @@
'..',
],
},
+ {
+ 'target_name': 'suid_sandbox_client',
+ 'type': 'static_library',
+ 'sources': [
+ 'suid/common/sandbox.h',
+ 'suid/common/suid_unsafe_environment_variables.h',
+ 'suid/client/setuid_sandbox_client.cc',
+ 'suid/client/setuid_sandbox_client.h',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ },
+
],
}
« no previous file with comments | « content/zygote/zygote_main_linux.cc ('k') | sandbox/linux/suid/client/setuid_sandbox_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698