Fix build break, i.e. fix type finalization for function literals not assigned

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 4300 matching lines @@
 
   // Make sure that the instantiator is captured.
   if ((signature_class.NumTypeParameters() > 0) &&
       (current_block_->scope->function_level() > 0)) {
     CaptureReceiver();
   }
 
   // Since the signature type is cached by the signature class, it may have
   // been finalized already.
   Type& signature_type = Type::Handle(signature_class.SignatureType());
-  const AbstractTypeArguments& signature_type_arguments =
+  AbstractTypeArguments& signature_type_arguments =
       AbstractTypeArguments::Handle(signature_type.arguments());
 
   if (!signature_type.IsFinalized()) {
     signature_type ^= ClassFinalizer::FinalizeType(
         signature_class, signature_type, ClassFinalizer::kCanonicalize);
+
     // The call to ClassFinalizer::FinalizeType may have
     // extended the vector of type arguments.
-    ASSERT(signature_type_arguments.IsNull() ||
+    signature_type_arguments = signature_type.arguments();
+    ASSERT(signature_type.IsMalformed() ||
+           signature_type_arguments.IsNull() ||
            (signature_type_arguments.Length() ==
             signature_class.NumTypeArguments()));
+
     // The signature_class should not have changed.
-    ASSERT(signature_type.type_class() == signature_class.raw());
+    ASSERT(signature_type.IsMalformed() ||
+           (signature_type.type_class() == signature_class.raw()));
   }
 
   if (variable_name != NULL) {
     // Patch the function type of the variable now that the signature is known.
     function_type.set_type_class(signature_class);
     function_type.set_arguments(signature_type_arguments);
 
+    // Mark the function type as malformed if the signature type is malformed.
+    if (signature_type.IsMalformed()) {
+      const Error& error = Error::Handle(signature_type.malformed_error());
+      function_type.set_malformed_error(error);
+    }
+
     // The function variable type should have been patched above.
     ASSERT((function_variable == NULL) ||
            (function_variable->type().raw() == function_type.raw()));
   }
 
   // The code generator does not compile the closure function when visiting
   // a ClosureNode. The generated code allocates a new Closure object containing
   // the current context. The type of the Closure object refers to the closure
   // function, which will be compiled on first invocation of the closure object.
   // Therefore, we ignore the parsed default_parameter_values and the
@@ skipping 4304 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart