Issue 10807009: Include the processId in webNavigation events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10807009: Include the processId in webNavigation events (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Include the processId in webNavigation events For provisional loads, this is not necessarily the correct ID, however, to determine the correct ID, I first have to change the frame tracking logic. BUG=136090 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147442

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+273 lines, -6 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/web_navigation_api_constants.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api_constants.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc	View	7 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/web_navigation.json	View	8 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/extensions/webNavigation.html	View	12 chunks	+213 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/static/webNavigation.html	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/framework.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

plz review This is the first step towards supporting processIds

8 years, 5 months ago (2012-07-18 11:40:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10807009/1

8 years, 5 months ago (2012-07-19 15:03:00 UTC) #3

commit-bot: I haz the power

8 years, 5 months ago (2012-07-19 15:03:04 UTC) #4

Presubmit check for 10807009-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/webNavigation.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

Expand Messages | Collapse Messages