Support proper emission of V8Scope handles.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 298 matching lines @@
           '        if (!RuntimeEnabledFeatures::$(FEATURE)Enabled()) {\n'
           '            exception = Dart_NewString("Feature $FEATURE is not enabled");\n'
           '            goto fail;\n'
           '        }',
           FEATURE=_ToWebKitName(ext_attrs['synthesizedV8EnabledAtRuntime']))
 
     self._GenerateNativeCallback(callback_name='constructorCallback',
         parameter_definitions=parameter_definitions_emitter.Fragments(),
         needs_receiver=False, invocation=invocation,
         raises_exceptions=raises_exceptions,
-        runtime_check=runtime_check)
+        runtime_check=runtime_check,
+        requires_v8_scope=self._RequiresV8Scope(ext_attrs, constructor_info.idl_args))
+
 
   def _ImplClassName(self, interface_name):
     return '_%sImpl' % interface_name
 
   def _BaseClassName(self):
     root_class = 'NativeFieldWrapperClass1'
 
     if not self._interface.parents:
       return root_class
 
@@ skipping 115 matching lines @@
     if call_with == 'ScriptExecutionContext':
       parameter_definitions_emitter.Emit(
           '\n'
           '        ScriptExecutionContext* context = DartUtilities::scriptExecutionContext();\n'
           '        if (!context)\n'
           '            return;\n')
       arguments.append('context')
       return False
 
     if call_with == 'ScriptArguments|CallStack':
-      self._cpp_impl_includes.add('"DOMWindow.h"')
       self._cpp_impl_includes.add('"ScriptArguments.h"')
       self._cpp_impl_includes.add('"ScriptCallStack.h"')
-      self._cpp_impl_includes.add('"V8Proxy.h"')
-      self._cpp_impl_includes.add('"v8.h"')
       parameter_definitions_emitter.Emit(
           '\n'
-          '        v8::HandleScope handleScope;\n'
-          '        v8::Context::Scope scope(V8Proxy::mainWorldContext(DartUtilities::domWindowForCurrentIsolate()->frame()));\n'
           '        Dart_Handle customArgument = Dart_GetNativeArgument(args, $INDEX);\n'
           '        RefPtr<ScriptArguments> scriptArguments(DartUtilities::createScriptArguments(customArgument, exception));\n'
           '        if (!scriptArguments)\n'
           '            goto fail;\n'
           '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
           '        if (!scriptCallStack->size())\n'
           '            return;\n',
           INDEX=len(node.arguments))
       arguments.extend(['scriptArguments', 'scriptCallStack'])
       return True
@@ skipping 13 matching lines @@
     type_info = self._TypeInfo(attr.type.id)
     dart_declaration = '%s get %s()' % (self._DartType(attr.type.id), html_name)
     is_custom = 'Custom' in attr.ext_attrs or 'CustomGetter' in attr.ext_attrs
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 1,
         dart_declaration, 'Getter', is_custom)
     if is_custom:
       return
 
     arguments = []
     parameter_definitions_emitter = emitter.Emitter()
-    raises_exceptions = self._GenerateCallWithHandling(attr, parameter_definitions_emitter, arguments)
+    raises_exceptions = self._GenerateCallWithHandling(
+        attr, parameter_definitions_emitter, arguments)
     raises_exceptions = raises_exceptions or attr.get_raises
 
     if 'Reflect' in attr.ext_attrs:
       webcore_function_name = self._TypeInfo(attr.type.id).webcore_getter_name()
       if 'URL' in attr.ext_attrs:
         if 'NonEmpty' in attr.ext_attrs:
           webcore_function_name = 'getNonEmptyURLAttribute'
         else:
           webcore_function_name = 'getURLAttribute'
       arguments.append(self._GenerateWebCoreReflectionAttributeName(attr))
     else:
       if attr.id == 'operator':
         webcore_function_name = '_operator'
       elif attr.id == 'target' and attr.type.id == 'SVGAnimatedString':
         webcore_function_name = 'svgTarget'
       else:
         webcore_function_name = _ToWebKitName(attr.id)
       if attr.type.id.startswith('SVGAnimated'):
         webcore_function_name += 'Animated'
 
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, attr)
     invocation = self._GenerateWebCoreInvocation(function_expression,
         arguments, attr.type.id, attr.ext_attrs, attr.get_raises)
     self._GenerateNativeCallback(cpp_callback_name, parameter_definitions_emitter.Fragments(),
-        True, invocation, raises_exceptions=raises_exceptions, runtime_check=None)
+        True, invocation, raises_exceptions=raises_exceptions,
+        runtime_check=None,
+        requires_v8_scope=self._RequiresV8Scope(attr.ext_attrs, []))
 
   def _AddSetter(self, attr, html_name):
     type_info = self._TypeInfo(attr.type.id)
     dart_declaration = 'void set %s(%s)' % (html_name, self._DartType(attr.type.id))
     is_custom = set(['Custom', 'CustomSetter', 'V8CustomSetter']) & set(attr.ext_attrs)
     cpp_callback_name = self._GenerateNativeBinding(attr.id, 2,
         dart_declaration, 'Setter', is_custom)
     if is_custom:
       return
 
@@ skipping 15 matching lines @@
     argument_expression = self._GenerateToNative(
         parameter_definitions_emitter, attr, 1, argument_name='value')
     arguments.append(argument_expression)
 
     parameter_definitions = parameter_definitions_emitter.Fragments()
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, attr)
     invocation = self._GenerateWebCoreInvocation(function_expression,
         arguments, 'void', attr.ext_attrs, attr.set_raises)
 
     self._GenerateNativeCallback(cpp_callback_name, parameter_definitions_emitter.Fragments(),
-        True, invocation, raises_exceptions=True, runtime_check=None)
+        True, invocation, raises_exceptions=True,
+        runtime_check=None,
+        requires_v8_scope=self._RequiresV8Scope(attr.ext_attrs, [attr]))
 
   def AddIndexer(self, element_type):
     """Adds all the methods required to complete implementation of List."""
     # We would like to simply inherit the implementation of everything except
     # get length(), [], and maybe []=.  It is possible to extend from a base
     # array implementation class only when there is no other implementation
     # inheritance.  There might be no implementation inheritance other than
     # DOMBaseWrapper for many classes, but there might be some where the
     # array-ness is introduced by a non-root interface:
     #
@@ skipping 215 matching lines @@
     if 'NeedsUserGestureCheck' in operation.ext_attrs:
       cpp_arguments.append('DartUtilities::processingUserGesture')
 
     function_expression = self._GenerateWebCoreFunctionExpression(webcore_function_name, operation)
     invocation = self._GenerateWebCoreInvocation(function_expression, cpp_arguments,
         operation.type.id, operation.ext_attrs, operation.raises)
     self._GenerateNativeCallback(cpp_callback_name,
         parameter_definitions=parameter_definitions_emitter.Fragments(),
         needs_receiver=not operation.is_static, invocation=invocation,
         raises_exceptions=raises_exceptions,
-        runtime_check=None)
+        runtime_check=None,
+        requires_v8_scope=self._RequiresV8Scope(operation.ext_attrs, arguments))
 
   def _GenerateNativeCallback(self, callback_name, parameter_definitions,
-      needs_receiver, invocation, raises_exceptions, runtime_check):
+      needs_receiver, invocation, raises_exceptions, runtime_check,
+      requires_v8_scope):
 
     head_emitter = emitter.Emitter()
 
+    if requires_v8_scope:
+      head_emitter.Emit(
+          '        V8Scope v8scope;\n\n')
+
     if runtime_check:
       head_emitter.Emit(
           '$RUNTIME_CHECK\n',
           RUNTIME_CHECK=runtime_check)
 
     if needs_receiver:
       head_emitter.Emit(
           '        $WEBCORE_CLASS_NAME* receiver = DartDOMWrapper::receiver< $WEBCORE_CLASS_NAME >(args);\n',
           WEBCORE_CLASS_NAME=self._interface_type_info.native_type())
 
@@ skipping 23 matching lines @@
     self._cpp_definitions_emitter.Emit(
         '\n'
         'static void $CALLBACK_NAME(Dart_NativeArguments args)\n'
         '{\n'
         '    DartApiScope dartApiScope;\n'
         '$BODY'
         '}\n',
         CALLBACK_NAME=callback_name,
         BODY=body)
 
-  def _GenerateToNative(self, emitter, idl_node, index,
-                                argument_name=None):
+  def _GenerateToNative(self, emitter, idl_node, index, argument_name=None):
     """idl_node is IDLArgument or IDLAttribute."""
     type_info = self._TypeInfo(idl_node.type.id)
     self._cpp_impl_includes |= set(type_info.to_native_includes())
     argument_name = argument_name or idl_node.id
     handle = 'Dart_GetNativeArgument(args, %i)' % index
-    return type_info.emit_to_native(emitter, idl_node, argument_name, handle, self._interface.id)
+    argument_expression = type_info.emit_to_native(
+        emitter, idl_node, argument_name, handle, self._interface.id)
+    return argument_expression
+
+  def _RequiresV8Scope(self, ext_attrs, arguments):
+    if 'CallWith' in ext_attrs and ext_attrs['CallWith'] == 'ScriptArguments|CallStack':
+      return True
+    for argument in arguments:
+      if self._TypeInfo(argument.type.id).requires_v8_scope():
+        return True
+    return False
 
   def _GenerateNativeBinding(self, idl_name, argument_count, dart_declaration,
       native_suffix, is_custom):
     native_binding = '%s_%s_%s' % (self._interface.id, idl_name, native_suffix)
     self._members_emitter.Emit(
         '\n'
         '  $DART_DECLARATION native "$NATIVE_BINDING";\n',
         DART_DECLARATION=dart_declaration, NATIVE_BINDING=native_binding)
 
     cpp_callback_name = '%s%s' % (idl_name, native_suffix)
@@ skipping 87 matching lines @@
 
 def _IsArgumentOptionalInWebCore(argument):
   return IsOptional(argument) and not 'Callback' in argument.ext_attrs
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)