Support proper emission of V8Scope handles.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 473 matching lines @@
 
   def idl_type(self):
     return self._idl_type
 
   def dart_type(self):
     return self._data.dart_type or self._idl_type
 
   def native_type(self):
     return self._data.native_type or self._idl_type
 
+  def requires_v8_scope(self):
+    return self._data.requires_v8_scope
+
   def emit_to_native(self, emitter, idl_node, name, handle, interface_name):
     if 'Callback' in idl_node.ext_attrs:
       if set(['Optional', 'Callback']).issubset(idl_node.ext_attrs.keys()):
         flag = 'DartUtilities::ConvertNullToDefaultValue'
       else:
         flag = 'DartUtilities::ConvertNone'
       emitter.Emit(
         '\n'
         '        RefPtr<$TYPE> $NAME = Dart$IDL_TYPE::create($HANDLE, $FLAG, exception);\n'
         '        if (exception)\n'
@@ skipping 75 matching lines @@
   def custom_to_dart(self):
     return self._data.custom_to_dart
 
 
 class InterfaceIDLTypeInfo(IDLTypeInfo):
   def __init__(self, idl_type, data):
     super(InterfaceIDLTypeInfo, self).__init__(idl_type, data)
 
 
 class SequenceIDLTypeInfo(IDLTypeInfo):
-  def __init__(self, idl_type, item_info):
-    super(SequenceIDLTypeInfo, self).__init__(idl_type, {})
+  def __init__(self, idl_type, data, item_info):
+    super(SequenceIDLTypeInfo, self).__init__(idl_type, data)
     self._item_info = item_info
 
   def dart_type(self):
     return 'List<%s>' % self._item_info.dart_type()
 
   def to_dart_conversion(self, value, interface_name=None, attributes=None):
     return 'DartDOMWrapper::vectorToDart<Dart%s>(%s)' % (self._item_info.native_type(), value)
 
   def conversion_includes(self):
     return self._item_info.conversion_includes()
 
 
 class DOMStringArrayTypeInfo(SequenceIDLTypeInfo):
-  def __init__(self, item_info):
-    super(DOMStringArrayTypeInfo, self).__init__('DOMString[]', item_info)
+  def __init__(self, data, item_info):
+    super(DOMStringArrayTypeInfo, self).__init__('DOMString[]', data, item_info)
 
   def emit_to_native(self, emitter, idl_node, name, handle, interface_name):
     emitter.Emit(
         '\n'
         '        RefPtr<DOMStringList> $NAME = DartDOMStringList::toNative($HANDLE, exception);\n'
         '        if (exception)\n'
         '            goto fail;\n',
         NAME=name,
         HANDLE=handle)
     return name
@@ skipping 89 matching lines @@
       conversion_cast = 'static_cast<%s*>(%s)'
     conversion_cast = conversion_cast % (self.native_type(), value)
     return 'Dart%s::toDart(%s)' % (self._idl_type, conversion_cast)
 
 
 class TypeData(object):
   def __init__(self, clazz, dart_type=None, native_type=None,
                custom_to_dart=None, custom_to_native=None,
                conversion_includes=None,
                webcore_getter_name='getAttribute',
-               webcore_setter_name='setAttribute'):
+               webcore_setter_name='setAttribute',
+               requires_v8_scope=False):
     self.clazz = clazz
     self.dart_type = dart_type
     self.native_type = native_type
     self.custom_to_dart = custom_to_dart
     self.custom_to_native = custom_to_native
     self.conversion_includes = conversion_includes
     self.webcore_getter_name = webcore_getter_name
     self.webcore_setter_name = webcore_setter_name
+    self.requires_v8_scope = requires_v8_scope
 
 
 _idl_type_registry = {
     'boolean': TypeData(clazz='Primitive', dart_type='bool', native_type='bool',
                         webcore_getter_name='hasAttribute',
                         webcore_setter_name='setBooleanAttribute'),
     'byte': TypeData(clazz='Primitive', dart_type='int', native_type='int'),
     'octet': TypeData(clazz='Primitive', dart_type='int', native_type='int'),
     'short': TypeData(clazz='Primitive', dart_type='int', native_type='int'),
     'unsigned short': TypeData(clazz='Primitive', dart_type='int',
@@ skipping 14 matching lines @@
     'double': TypeData(clazz='Primitive', dart_type='num'),
 
     'any': TypeData(clazz='Primitive', dart_type='Object'),
     'Array': TypeData(clazz='Primitive', dart_type='List'),
     'custom': TypeData(clazz='Primitive', dart_type='Dynamic'),
     'Date': TypeData(clazz='Primitive', dart_type='Date', native_type='double'),
     'DOMObject': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue'),
     'DOMString': TypeData(clazz='Primitive', dart_type='String', native_type='String'),
     # TODO(vsm): This won't actually work until we convert the Map to
     # a native JS Map for JS DOM.
-    'Dictionary': TypeData(clazz='Primitive', dart_type='Map'),
+    'Dictionary': TypeData(clazz='Primitive', dart_type='Map', requires_v8_scope=True),
     # TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
     # http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
     'Flags': TypeData(clazz='Primitive', dart_type='Object'),
     'DOMTimeStamp': TypeData(clazz='Primitive', dart_type='int', native_type='unsigned long long'),
     'object': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue'),
     'PositionOptions': TypeData(clazz='Primitive', dart_type='Object'),
     # TODO(sra): Come up with some meaningful name so that where this appears in
     # the documentation, the user is made aware that only a limited subset of
     # serializable types are actually permitted.
     'SerializedScriptValue': TypeData(clazz='Primitive', dart_type='Dynamic'),
@@ skipping 64 matching lines @@
       if self._renamer:
         return self._renamer.RenameInterface(interface)
       else:
         return interface.id
     return dart_type
 
   def _TypeInfo(self, type_name):
     match = re.match(r'(?:sequence<(\w+)>|(\w+)\[\])$', type_name)
     if match:
       if type_name == 'DOMString[]':
-        return DOMStringArrayTypeInfo(self.TypeInfo('DOMString'))
-      return SequenceIDLTypeInfo(type_name, self.TypeInfo(match.group(1) or match.group(2)))
+        return DOMStringArrayTypeInfo(TypeData('Sequence'), self.TypeInfo('DOMString'))
+      item_info = self.TypeInfo(match.group(1) or match.group(2))
+      return SequenceIDLTypeInfo(type_name, TypeData('Sequence'), item_info)
     if not type_name in _idl_type_registry:
       return InterfaceIDLTypeInfo(type_name, TypeData('Interface'))
     type_data = _idl_type_registry.get(type_name)
     class_name = '%sIDLTypeInfo' % type_data.clazz
     return globals()[class_name](type_name, type_data)