Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: build/copy_test_data_ios.py

Issue 10807006: Ignore dotfiles when copying test data. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add TODO. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/copy_test_data_ios.py
diff --git a/build/copy_test_data_ios.py b/build/copy_test_data_ios.py
index e6c6a386084624085125ff0a5aad5600dcb2b1b9..51307358355ecdbf078e5e15d624829ea40ed8cf 100755
--- a/build/copy_test_data_ios.py
+++ b/build/copy_test_data_ios.py
@@ -16,6 +16,12 @@ class WrongNumberOfArgumentsException(Exception):
def ListFilesForPath(path):
"""Returns a list of all the files under a given path."""
output = []
+ # Ignore dotfiles and dot directories.
+ # TODO(rohitrao): This will fail to exclude cases where the initial argument
+ # is a relative path that starts with a dot.
+ if os.path.basename(path).startswith('.'):
+ return output
+
# Files get returned without modification.
if not os.path.isdir(path):
output.append(path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698