Issue 10807003: Revert 147169 - Add support for encrypted WebM files as defined in the RFC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10807003: Revert 147169 - Add support for encrypted WebM files as defined in the RFC. (Closed)

Created:
8 years, 5 months ago by jln (very slow on Chromium)

Modified:
8 years, 5 months ago

Reviewers:
fgalligan1

CC:
chromium-reviews, feature-media-reviews_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 147169 - Add support for encrypted WebM files as defined in the RFC. The WebM parser now reads the HMAC and IV from every encrypted Block and stores that information in the DecryptorConfig object. Added two new elements ContentEncAESSettings and AESSettingsCipherMode used by encrypted WebM files. BUG=119845 TEST=media_unittests --gtest_filter=HmacAesDecryptorTest Review URL: https://chromiumcodereview.appspot.com/10535029 TBR=fgalligan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147172

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -729 lines)			Patch
M	media/base/decrypt_config.h	View	1 chunk	+4 lines, -35 lines	0 comments	Download
M	media/base/decrypt_config.cc	View	1 chunk	+3 lines, -17 lines	0 comments	Download
M	media/crypto/aes_decryptor.h	View	3 chunks	+3 lines, -43 lines	0 comments	Download
M	media/crypto/aes_decryptor.cc	View	8 chunks	+24 lines, -162 lines	0 comments	Download
M	media/crypto/aes_decryptor_unittest.cc	View	3 chunks	+71 lines, -297 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	7 chunks	+24 lines, -63 lines	0 comments	Download
M	media/filters/pipeline_integration_test.cc	View	4 chunks	+5 lines, -11 lines	0 comments	Download
M	media/webm/webm_cluster_parser.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/webm/webm_cluster_parser.cc	View	2 chunks	+3 lines, -40 lines	0 comments	Download
M	media/webm/webm_constants.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	media/webm/webm_content_encodings.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	media/webm/webm_content_encodings.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	media/webm/webm_content_encodings_client.cc	View	3 chunks	+0 lines, -29 lines	0 comments	Download
M	media/webm/webm_parser.cc	View	4 chunks	+0 lines, -9 lines	0 comments	Download
M	media/webm/webm_stream_parser.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

8 years, 5 months ago (2012-07-18 04:09:42 UTC) #2

cc1plus: warnings being treated as errors
media/filters/ffmpeg_video_decoder_unittest.cc:59: error: this decimal
constant is unsigned only in ISO C90
make: ***
[out/Release/obj.target/media_unittests/media/filters/ffmpeg_video_decoder_unittest.o]
Error 1

Expand Messages | Collapse Messages