Issue 10806096: Add base/md5* to ThreadSanitizer ignore list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806096: Add base/md5* to ThreadSanitizer ignore list. (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)

Modified:
8 years, 5 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, pam+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base/md5* to ThreadSanitizer ignore list. MD5 computation is a series of many tiny function calls, which causes tsan to slow down. For example, MD5 computation accounted for ~38% of samples when running media_unittests PipelineIntegrationTest.BasicPlaybackHashed. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148596

Patch Set 1 #

Patch Set 2 : md5 #

Total comments: 2

Patch Set 3 : fix comment #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/valgrind/tsan/ignores.txt	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM with one suggestion. It's strange we still have the trybot timing out though :( ...

8 years, 5 months ago (2012-07-26 15:53:00 UTC) #2

scherkus (not reviewing)

8 years, 5 months ago (2012-07-26 18:02:48 UTC) #3

https://chromiumcodereview.appspot.com/10806096/diff/4001/tools/valgrind/tsan...
File tools/valgrind/tsan/ignores.txt (right):

https://chromiumcodereview.appspot.com/10806096/diff/4001/tools/valgrind/tsan...
tools/valgrind/tsan/ignores.txt:69: # repeatedly calling tiny functions.
On 2012/07/26 15:53:01, Timur Iskhodzhanov wrote:
> Please add "... which are unlikely to race with anything" if you think this is
> the case :)

Done.

Expand Messages | Collapse Messages