Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: chrome/installer/util/chrome_binaries_operations.cc

Issue 10806086: Fix multi-install update regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/util_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/chrome_binaries_operations.cc
diff --git a/chrome/installer/util/chrome_binaries_operations.cc b/chrome/installer/util/chrome_binaries_operations.cc
index 326223a2726ca58ced95630a852f7465084f2035..864be81408e6b45ee07bc622c721a11e18c9de48 100644
--- a/chrome/installer/util/chrome_binaries_operations.cc
+++ b/chrome/installer/util/chrome_binaries_operations.cc
@@ -19,22 +19,14 @@ void ChromeBinariesOperations::ReadOptions(
const MasterPreferences& prefs,
std::set<std::wstring>* options) const {
DCHECK(options);
-
- bool pref_value;
-
- if (prefs.GetBool(master_preferences::kMultiInstall, &pref_value) &&
- pref_value) {
- options->insert(kOptionMultiInstall);
- }
+ options->insert(kOptionMultiInstall);
}
void ChromeBinariesOperations::ReadOptions(
const CommandLine& uninstall_command,
std::set<std::wstring>* options) const {
DCHECK(options);
-
- if (uninstall_command.HasSwitch(switches::kMultiInstall))
- options->insert(kOptionMultiInstall);
+ options->insert(kOptionMultiInstall);
}
void ChromeBinariesOperations::AddKeyFiles(
@@ -54,11 +46,11 @@ void ChromeBinariesOperations::AppendProductFlags(
CommandLine* cmd_line) const {
DCHECK(cmd_line);
- if (options.find(kOptionMultiInstall) != options.end()) {
- // Add --multi-install if it isn't already there.
- if (!cmd_line->HasSwitch(switches::kMultiInstall))
- cmd_line->AppendSwitch(switches::kMultiInstall);
- }
+ DCHECK(options.find(kOptionMultiInstall) != options.end());
+
+ // Add --multi-install if it isn't already there.
+ if (!cmd_line->HasSwitch(switches::kMultiInstall))
+ cmd_line->AppendSwitch(switches::kMultiInstall);
}
void ChromeBinariesOperations::AppendRenameFlags(
@@ -66,11 +58,11 @@ void ChromeBinariesOperations::AppendRenameFlags(
CommandLine* cmd_line) const {
DCHECK(cmd_line);
+ DCHECK(options.find(kOptionMultiInstall) != options.end());
+
// Add --multi-install if it isn't already there.
- if (options.find(kOptionMultiInstall) != options.end() &&
- !cmd_line->HasSwitch(switches::kMultiInstall)) {
+ if (!cmd_line->HasSwitch(switches::kMultiInstall))
cmd_line->AppendSwitch(switches::kMultiInstall);
- }
}
bool ChromeBinariesOperations::SetChannelFlags(
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/util_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698