Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 10806082: Remove all uncessary files for build_nexe.py on Windows. (Closed)

Created:
8 years, 5 months ago by Hironori Bono
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Remove all uncessary files for build_nexe.py on Windows. On Windows, cmd.exe crops the command-line string for build_nexe.py and build_nexe.py does not get all base files now. This change removes all files not needed by build_nexe.py on Windows to prevent cmd.exe from cropping the command-line string to build_nexe.py. BUG=138687 TEST=build Chromium without errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/base.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
Greetings, Currently, due to a problem of build_nexe.py on Windows <http://crrev.com/148055>, it is almost improssible ...
8 years, 5 months ago (2012-07-24 09:21:45 UTC) #1
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-24 12:58:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10806082/1
8 years, 5 months ago (2012-07-25 00:32:13 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 02:32:12 UTC) #4
Change committed as 148280

Powered by Google App Engine
This is Rietveld 408576698