Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: runtime/vm/bit_set.h

Issue 10806078: Improve the performance of bit set searches with a compiler intrinsic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/platform/utils_win.h ('k') | runtime/vm/freelist.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_BIT_SET_H_ 5 #ifndef VM_BIT_SET_H_
6 #define VM_BIT_SET_H_ 6 #define VM_BIT_SET_H_
7 7
8 #include "platform/utils.h"
8 #include "vm/globals.h" 9 #include "vm/globals.h"
9 10
10 namespace dart { 11 namespace dart {
11 12
12 // Just like its namesake in the STL, a BitSet object contains a fixed 13 // Just like its namesake in the STL, a BitSet object contains a fixed
13 // length sequence of bits. 14 // length sequence of bits.
14 template<intptr_t N> 15 template<intptr_t N>
15 class BitSet { 16 class BitSet {
16 public: 17 public:
17 BitSet() { 18 BitSet() {
(...skipping 11 matching lines...) Expand all
29 } 30 }
30 } 31 }
31 32
32 bool Test(intptr_t i) { 33 bool Test(intptr_t i) {
33 ASSERT(i >= 0); 34 ASSERT(i >= 0);
34 ASSERT(i < N); 35 ASSERT(i < N);
35 uword mask = (static_cast<uword>(1) << (i % kBitsPerWord)); 36 uword mask = (static_cast<uword>(1) << (i % kBitsPerWord));
36 return (data_[i / kBitsPerWord] & mask) != 0; 37 return (data_[i / kBitsPerWord] & mask) != 0;
37 } 38 }
38 39
40 intptr_t Next(intptr_t i) {
41 ASSERT(i >= 0);
42 ASSERT(i < N);
43 intptr_t w = i / kBitsPerWord;
44 uword mask = ~static_cast<uword>(0) << i;
45 if ((data_[w] & mask) != 0) {
46 uword tz = Utils::CountTrailingZeros(data_[w] & mask);
47 return kBitsPerWord*w + tz;
48 }
49 while (++w < (1 + ((N - 1) / kBitsPerWord))) {
50 if (data_[w] != 0) {
51 return kBitsPerWord*w + Utils::CountTrailingZeros(data_[w]);
52 }
53 }
54 return -1;
55 }
56
39 void Reset() { 57 void Reset() {
40 memset(data_, 0, sizeof(data_)); 58 memset(data_, 0, sizeof(data_));
41 } 59 }
42 60
43 intptr_t Size() const { 61 intptr_t Size() const {
44 return N; 62 return N;
45 } 63 }
46 64
47 private: 65 private:
48 uword data_[1 + ((N - 1) / kBitsPerWord)]; 66 uword data_[1 + ((N - 1) / kBitsPerWord)];
49 }; 67 };
50 68
51 } // namespace dart 69 } // namespace dart
52 70
53 #endif // VM_BIT_SET_H_ 71 #endif // VM_BIT_SET_H_
OLDNEW
« no previous file with comments | « runtime/platform/utils_win.h ('k') | runtime/vm/freelist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698