Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10806076: Move ZygoteHost implementation to content/browser/zygote_host (Closed)

Created:
8 years, 5 months ago by jln (very slow on Chromium)
Modified:
8 years, 5 months ago
Reviewers:
jam, sky, Chris Evans
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Markus (顧孟勤)
Visibility:
Public.

Description

Move zygote_host_impl_linux.* to content/browser/zygote_host BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148026

Patch Set 1 #

Patch Set 2 : Move the ZygoteHost implementation to content/browser/zygote_host #

Patch Set 3 : Rebase on top of tree #

Patch Set 4 : Add an empty line to the OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -557 lines) Patch
M content/browser/OWNERS View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/zygote_host/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/zygote_host/zygote_host_impl_linux.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/zygote_host/zygote_host_impl_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/browser/zygote_host_impl_linux.h View 1 1 chunk +0 lines, -68 lines 0 comments Download
D content/browser/zygote_host_impl_linux.cc View 1 2 1 chunk +0 lines, -480 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jln (very slow on Chromium)
Oops, looks like we missed keeping that file in sync!
8 years, 5 months ago (2012-07-23 21:39:24 UTC) #1
jam
can you instead move those files to content/browser/zygote_host and add the owners file there?
8 years, 5 months ago (2012-07-23 21:44:15 UTC) #2
jln (very slow on Chromium)
On 2012/07/23 21:44:15, John Abd-El-Malek wrote: > can you instead move those files to content/browser/zygote_host ...
8 years, 5 months ago (2012-07-23 21:59:41 UTC) #3
jam
lgtm, thanks
8 years, 5 months ago (2012-07-23 22:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10806076/1002
8 years, 5 months ago (2012-07-23 23:38:41 UTC) #5
commit-bot: I haz the power
Can't process patch for file content/browser/OWNERS. Hunk header is incorrect: -3 vs -4
8 years, 5 months ago (2012-07-23 23:38:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10806076/10001
8 years, 5 months ago (2012-07-23 23:52:29 UTC) #7
commit-bot: I haz the power
Can't process patch for file content/browser/OWNERS. Hunk header is incorrect: -3 vs -4
8 years, 5 months ago (2012-07-23 23:52:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10806076/9003
8 years, 5 months ago (2012-07-23 23:54:58 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 01:31:32 UTC) #10 
Change committed as 148026

Powered by Google App Engine
This is Rietveld 408576698