Issue 10806075: Get the path of the plugin interposing library from the embedder, since they're the ones who bundle…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806075: Get the path of the plugin interposing library from the embedder, since they're the ones who bundle… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get the path of the plugin interposing library from the embedder, since they're the ones who bundle it. Make content still work without it. This allows plugins to work inside content_shell. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147965

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
M	chrome/common/chrome_content_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/plugin_process_host.cc	View		1 chunk	+11 lines, -8 lines	0 comments	Download
M	content/common/plugin_carbon_interpose_constants_mac.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/plugin_carbon_interpose_constants_mac.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/plugin/plugin_main_mac.mm	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/public/common/content_client.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/common/content_client.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

The gyp rules in chrome.gyp seemed unfortunate to duplicate in content.gyp (and couldn't just be ...

8 years, 5 months ago (2012-07-23 21:15:37 UTC) #1

Avi (use Gerrit)

8 years, 5 months ago (2012-07-23 21:17:53 UTC) #2

Sob.

LGTM

Hope we don't have to deal with this much longer.

Expand Messages | Collapse Messages