Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10806061: Initialize the shared memory to appease Valgrind. (Closed)

Created:
8 years, 5 months ago by tommi (sloooow) - chröme
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Initialize the shared memory to appease Valgrind. BUG=138515 TEST=Under valgrind, run: content_unittests --gtest_filter=AudioDeviceTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147848

Patch Set 1 #

Patch Set 2 : CreateAndMap #

Patch Set 3 : Zero out the data in the Render callback #

Patch Set 4 : Update suppressions #

Total comments: 5

Patch Set 5 : Fix AudioDevice::AudioThreadCallback::Process which could touch uninitialized data. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M content/renderer/media/audio_device.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/audio_device_unittest.cc View 1 2 3 4 3 chunks +31 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
8 years, 5 months ago (2012-07-23 10:42:02 UTC) #1
henrika (OOO until Aug 14)
LGTM w/ nits. But linux_valgrind is read... https://chromiumcodereview.appspot.com/10806061/diff/1003/content/renderer/media/audio_device_unittest.cc File content/renderer/media/audio_device_unittest.cc (right): https://chromiumcodereview.appspot.com/10806061/diff/1003/content/renderer/media/audio_device_unittest.cc#newcode116 content/renderer/media/audio_device_unittest.cc:116: int number_of_frames, ...
8 years, 5 months ago (2012-07-23 11:17:06 UTC) #2
tommi (sloooow) - chröme
A few try runs were red due to patch problems (the revision that updated the ...
8 years, 5 months ago (2012-07-23 12:23:09 UTC) #3
henrika (OOO until Aug 14)
LGTM.
8 years, 5 months ago (2012-07-23 13:02:15 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 13:11:09 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698