chrome/browser/ui/views/location_bar/page_action_image_view.h - Issue 10806058: Move icon fallbacks into ExtensionAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 10806058: Move icon fallbacks into ExtensionAction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move the icon cache inside ExtensionAction. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/page_action_image_view.h

diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.h b/chrome/browser/ui/views/location_bar/page_action_image_view.h

index c103ac53943b33afe78f66af656fba1addf42154..56ee10c80c5df9853f9a355a8d87eb5acca7b87e 100644

--- a/chrome/browser/ui/views/location_bar/page_action_image_view.h

+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.h

@@ -103,10 +103,6 @@ class PageActionImageView : public views::ImageView,

// The corresponding browser.

Browser* browser_;

- // A cache of bitmaps the page actions might need to show, mapped by path.

- typedef std::map<std::string, SkBitmap> PageActionMap;

- PageActionMap page_action_icons_;

// The object that is waiting for the image loading to complete

// asynchronously.

ImageLoadingTracker tracker_;