Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10806056: Move plugin_browsertests.cc from browser_tests to content_browsertests. (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
sky, Nirnimesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move plugin_browsertests.cc from browser_tests to content_browsertests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147983

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix mac #

Patch Set 6 : sync to mac+win fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -1585 lines) Patch
M chrome/browser/fast_shutdown_browsertest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser_tests.isolate View 1 2 3 4 5 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 5 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 1 2 3 4 5 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/base/test_launcher_utils.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 1 comment Download
M chrome/test/base/ui_test_utils.h View 1 2 3 4 5 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/ui_test_utils_mac.mm View 1 2 3 4 5 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/npapi/alert_in_window_message.html View 1 2 3 4 5 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/test/data/npapi/arguments.html View 1 2 3 4 5 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/data/npapi/convert_point.html View 1 2 3 4 5 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/npapi/create_instance_in_paint.html View 1 2 3 4 5 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/test/data/npapi/ensure_scripting_works_in_destroy.html View 1 2 3 4 5 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/test/data/npapi/ensure_scripting_works_in_destroy_iframe.html View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/npapi/execute_script_delete_in_mouse_up.html View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/data/npapi/execute_script_delete_in_npn_evaluate.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/test/data/npapi/execute_script_delete_in_paint.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/test/data/npapi/get_javascript_open_popup_with_plugin.html View 1 2 3 4 5 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/npapi/get_javascript_url.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/get_javascript_url2.html View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/npapi/get_javascript_url2_frame.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/geturl.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/geturl_redirect_notify.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/layout_test_plugin.html View 1 2 3 4 5 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/npapi/many_plugins.html View 1 2 3 4 5 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/test/data/npapi/multiple_instances_sync_calls.html View 1 2 3 4 5 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/data/npapi/new_fails.html View 1 2 3 4 5 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/data/npapi/no_hang_if_init_crashes.html View 1 2 3 4 5 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/npapi/npapi.js View 1 2 3 4 5 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/data/npapi/npn_plugin_delete_create_in_evaluate.html View 1 2 3 4 5 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/data/npapi/npobject_identity.html View 1 2 3 4 5 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/npapi/npobject_lifetime_test.html View 1 2 3 4 5 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/test/data/npapi/npobject_lifetime_test_second_instance.html View 1 2 3 4 5 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/npapi/npobject_proxy.html View 1 2 3 4 5 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/data/npapi/npobject_released_on_destruction.html View 1 2 3 4 5 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/data/npapi/npobject_set_exception.html View 1 2 3 4 5 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/npapi/plugin_delete_in_deallocate.html View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/test/data/npapi/plugin_read_page.html View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/npapi/plugin_read_page.html.mock-http-headers View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/npapi/plugin_read_page_redirect_src.html View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/npapi/plugin_read_page_redirect_src.html.mock-http-headers View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/npapi/plugin_ref_target_page.html View 1 2 3 4 5 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/npapi/plugin_ref_target_page.html.mock-http-headers View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/npapi/plugin_thread_async_call.html View 1 2 3 4 5 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/test/data/npapi/plugin_url_request_404.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/plugin_url_request_fail_write.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/plugin_url_request_referrer_test.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/npapi/popup_window_with_target_plugin.html View 1 2 3 4 5 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/npapi/private.html View 1 2 3 4 5 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/test/data/npapi/schedule_timer.html View 1 2 3 4 5 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/test/data/npapi/self_delete_plugin_geturl.html View 1 2 3 4 5 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/test/data/npapi/self_delete_plugin_invoke.html View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/data/npapi/self_delete_plugin_invoke_alert.html View 1 2 3 4 5 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/test/data/npapi/self_delete_plugin_stream.html View 1 2 3 4 5 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/data/npapi/verify_plugin_window_rect.html View 1 2 3 4 5 1 chunk +0 lines, -30 lines 0 comments Download
M content/DEPS View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 2 3 4 5 12 chunks +45 lines, -58 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/test/test_utils.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell.h View 1 2 3 4 5 3 chunks +23 lines, -22 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_creator.h View 1 2 3 4 5 3 chunks +9 lines, -0 lines 0 comments Download
M content/shell/shell_javascript_dialog_creator.cc View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
M content/shell/shell_switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_switches.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/browser_test_base.h View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M content/test/browser_test_base.cc View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M content/test/content_browser_test.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/test/content_browser_test.cc View 1 2 3 4 5 3 chunks +11 lines, -1 line 0 comments Download
M content/test/content_browser_test_test.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/content_browser_test_utils.h View 1 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M content/test/content_browser_test_utils.cc View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
A content/test/content_browser_test_utils_mac.mm View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + content/test/data/page404.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/page404.html.mock-http-headers View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M content/test/data/simple_page.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 5 months ago (2012-07-23 05:37:08 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-23 15:57:30 UTC) #2
Nirnimesh
8 years, 5 months ago (2012-07-24 21:10:59 UTC) #3 
https://chromiumcodereview.appspot.com/10806056/diff/15011/chrome/test/base/t...
File chrome/test/base/test_launcher_utils.cc (left):

https://chromiumcodereview.appspot.com/10806056/diff/15011/chrome/test/base/t...
chrome/test/base/test_launcher_utils.cc:52: // The tests assume that file://
URIs can freely access other file:// URIs.
This has broken up all pyauto usage completely. All pyauto tests are failing
because of it. Affects chromeos too.

Powered by Google App Engine
This is Rietveld 408576698