Fix aura::Window::ContainsPointInRoot().

Fix aura::Window::ContainsPointInRoot().

Currently, the function tries to compare a point in the window's coordinates and a rect in the root window's coordinates.

BUG=None
TEST=added a unit test (WindowTest.ContainsPointInRoot) which fails on tot and passes with this CL; ./out/Debug/aura_unittests --gtest_filter='*WindowTest.ContainsPoint*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147930

[oshima, 2012-07-21 13:25:03]

lgtm with nits

http://codereview.chromium.org/10806055/diff/1/ui/aura/window.cc
File ui/aura/window.cc (right):

http://codereview.chromium.org/10806055/diff/1/ui/aura/window.cc#newcode491
ui/aura/window.cc:491: GetTargetBounds().size()).Contains(local_point);
gfx::Rect(GetTargetBounds().size()).Contains(local_point);

can you fix ContainsPoint while we're at it?

[Yusuke Sato, 2012-07-23 16:39:42]

+sky,
Could you do an owners review?

http://codereview.chromium.org/10806055/diff/1/ui/aura/window.cc
File ui/aura/window.cc (right):

http://codereview.chromium.org/10806055/diff/1/ui/aura/window.cc#newcode491
ui/aura/window.cc:491: GetTargetBounds().size()).Contains(local_point);
On 2012/07/21 13:25:04, oshima wrote:
> gfx::Rect(GetTargetBounds().size()).Contains(local_point);
> 
> can you fix ContainsPoint while we're at it?

Done.

[sky, 2012-07-23 18:22:33]

LGTM

[commit-bot: I haz the power, 2012-07-23 18:23:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10806055/3002

[commit-bot: I haz the power, 2012-07-23 19:40:47]

Try job failure for 10806055-3002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-23 19:50:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10806055/3002