Change the navigation code of sync promo slightly to navigate

Change the navigation code of sync promo slightly to navigate
to the next URL only if the URL is not empty. IF the URL is empty
then close the ui.

BUG=124493
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147970

[sail, 2012-07-20 22:43:45]

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.h (right):

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.h:20: SOURCE_EXTENSION_API,
Are you planning to use this later? I don't see a reference to this anywhere in
this CL.

Also, this enum is used to collect some UMA data. You'll have to also update
this code:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/webui/sy...
and the SyncPromoShowAndSignIn enum in tools/histogram/histograms.xml

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.h:59: static GURL
GetSyncPromoURL(
I don't think it's worth overloading this function. you can just add auto_close
to the original function

[Munjal (Google), 2012-07-20 23:04:35]

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.h (right):

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.h:20: SOURCE_EXTENSION_API,
On 2012/07/20 22:43:45, sail wrote:
> Are you planning to use this later? I don't see a reference to this anywhere
in
> this CL.
> 
> Also, this enum is used to collect some UMA data. You'll have to also update
> this code:
>
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/webui/sy...
> and the SyncPromoShowAndSignIn enum in tools/histogram/histograms.xml

Yeah, I am using it in a different patch. But actually let me add this in a
separate CL to keep this patch focused.

http://codereview.chromium.org/10806048/diff/6001/chrome/browser/ui/webui/syn...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.h:59: static GURL
GetSyncPromoURL(
On 2012/07/20 22:43:45, sail wrote:
> I don't think it's worth overloading this function. you can just add
auto_close
> to the original function

Done.

[sail, 2012-07-20 23:06:42]

Looks good!
LGTM!

[commit-bot: I haz the power, 2012-07-20 23:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/10806048/3005

[commit-bot: I haz the power, 2012-07-20 23:12:13]

Presubmit check for 10806048-3005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 4.0s to calculate.

[Munjal (Google), 2012-07-23 17:39:31]

Adding sky@ for OWNERS

[sky, 2012-07-23 18:31:20]

LGTM

https://chromiumcodereview.appspot.com/10806048/diff/3005/chrome/browser/ui/w...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc (right):

https://chromiumcodereview.appspot.com/10806048/diff/3005/chrome/browser/ui/w...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc:210: const GURL& next_page,
Source source, bool auto_close) {
nit: when you wrap, each param on its own line.

[Munjal (Google), 2012-07-23 18:35:18]

https://chromiumcodereview.appspot.com/10806048/diff/3005/chrome/browser/ui/w...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc (right):

https://chromiumcodereview.appspot.com/10806048/diff/3005/chrome/browser/ui/w...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc:210: const GURL& next_page,
Source source, bool auto_close) {
On 2012/07/23 18:31:20, sky wrote:
> nit: when you wrap, each param on its own line.

Done.

[commit-bot: I haz the power, 2012-07-23 18:35:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/10806048/6006

[commit-bot: I haz the power, 2012-07-23 20:39:58]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-07-23 21:05:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/10806048/6006

[commit-bot: I haz the power, 2012-07-23 22:30:24]

Change committed as 147970