Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10806028: Implement unittests for IBusEngineService (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka
Modified:
8 years, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@engine_service
Visibility:
Public.

Description

Implement unittests for IBusEngineService BUG=126947 TEST=chromeos_unittests and try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148068

Patch Set 1 : Style fix #

Patch Set 2 : Fix GYP order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+909 lines, -1 line) Patch
M chromeos/chromeos.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
A chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 1 chunk +907 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
I'm sorry for big CL, but I want you to review this CL.
8 years, 5 months ago (2012-07-19 08:31:41 UTC) #1
satorux1
LGTM
8 years, 5 months ago (2012-07-23 21:04:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10806028/5003
8 years, 5 months ago (2012-07-24 04:37:46 UTC) #3
commit-bot: I haz the power
Try job failure for 10806028-5003 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-24 06:11:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10806028/5003
8 years, 5 months ago (2012-07-24 06:12:28 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 09:00:29 UTC) #6
Change committed as 148068

Powered by Google App Engine
This is Rietveld 408576698