Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 10806025: Revert 147309 - Annotate calls to SQLite functions - they have to be executed on a thread allowing … (Closed)

Created:
8 years, 5 months ago by Scott Hess - ex-Googler
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 147309 - Annotate calls to SQLite functions - they have to be executed on a thread allowing IO access. Expand scope of ScopedAllowIO in the only place where SQLite functions are used on UI thread. Patch from Pavel Ivanov <paivanof@gmail.com>; BUG=75232, 52909, 137961 TEST=no test fails with message "Function marked as IO-only was called from a thread that disallows IO!" Review URL: https://chromiumcodereview.appspot.com/10540155 Patch from Pavel Ivanov <paivanof@gmail.com>;. TBR=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -58 lines) Patch
M chrome/browser/net/sqlite_server_bound_cert_store.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M sql/connection.h View 5 chunks +1 line, -18 lines 0 comments Download
M sql/connection.cc View 10 chunks +1 line, -28 lines 0 comments Download
M sql/statement.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Hess - ex-Googler
8 years, 5 months ago (2012-07-18 23:48:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698