Issue 10806022: Removing usage of profile_->GetHistory() from the codebase in order to remove that function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806022: Removing usage of profile_->GetHistory() from the codebase in order to remove that function. (Closed)

Created:
8 years, 5 months ago by rpetterson

Modified:
8 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Removing usage of profile_->GetHistory() from the codebase in order to remove that function. This was previously reverted, found not to be the cause of the issue, now I am reinstating the changes. BUG=97804 TEST=existing unittests TBR=sky@chromium.org,shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147962

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
M	chrome/browser/ui/cocoa/history_menu_bridge.mm	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10806022/8001

8 years, 5 months ago (2012-07-23 20:45:45 UTC) #1

Change committed as 147962