Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: lib/dom/templates/html/interface/interface_Element.darttemplate

Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update Dromaeo sample Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/interface/interface_Element.darttemplate
diff --git a/lib/dom/templates/html/interface/interface_Element.darttemplate b/lib/dom/templates/html/interface/interface_Element.darttemplate
index dee20666cd9a71ed1f525cdd3d26dba62082bfaf..ebf563b2b2c55c8b701614e9b09f1e2474038c90 100644
--- a/lib/dom/templates/html/interface/interface_Element.darttemplate
+++ b/lib/dom/templates/html/interface/interface_Element.darttemplate
@@ -4,7 +4,11 @@
// WARNING: Do not edit - generated code.
-interface ElementList extends List<Element> {
+// TODO(vsm): Eliminate this type.
+
+// Note, ElementList implements List so that it's implementing classes
sra1 2012/07/19 00:44:00 Not sure I follow. ElementList extends raw List s
+// may be cast to List<? extends Element> - e.g., List<CanvasElement>.
+interface ElementList extends List {
// TODO(jacobr): add element batch manipulation methods.
ElementList filter(bool f(Element element));
@@ -39,7 +43,7 @@ interface ElementRect {
interface NodeSelector {
Element query(String selectors);
- NodeList queryAll(String selectors);
+ List<Element> queryAll(String selectors);
}
$!COMMENT

Powered by Google App Engine
This is Rietveld 408576698