Issue 10806006: Implement IBusEngineService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806006: Implement IBusEngineService (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka

Modified:
8 years, 5 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Implement IBusEngineService With this CL, IBusEngineService can handle MethodCall and Signal emitting. To avoid CL delta bloat, let me split the CL. I will send CL for unit tests soon. BUG=126947 TEST=try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148038

Patch Set 1 #

Patch Set 2 : CL for review #

Patch Set 3 : Fix wrong usage of Message #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+387 lines, -15 lines)			Patch
	M	chromeos/dbus/ibus/ibus_constants.h	View		1 chunk	+20 lines, -0 lines	0 comments	Download
	M	chromeos/dbus/ibus/ibus_engine_service.cc	View	1 2	4 chunks	+367 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10806006/1007

8 years, 5 months ago (2012-07-24 00:48:36 UTC) #3

Change committed as 148038

Expand Messages | Collapse Messages