runtime/platform/utils_linux.h - Issue 10805080: Fix the build breakage on MacOS and Windows caused by CountTrailingZeros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/platform/utils_linux.h

Issue 10805080: Fix the build breakage on MacOS and Windows caused by CountTrailingZeros. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/platform/utils_linux.h

diff --git a/runtime/platform/utils_linux.h b/runtime/platform/utils_linux.h

index 68316823ee769b5f27dcebf112ca82c3403e7c6b..6cfc32f5a2e10707b603f884e39f74f3b9810e46 100644

--- a/runtime/platform/utils_linux.h

+++ b/runtime/platform/utils_linux.h

@@ -7,12 +7,14 @@

namespace dart {

-inline int Utils::CountTrailingZeros(uint32_t x) {

+inline int Utils::CountTrailingZeros(uword x) {

+#if defined(ARCH_IS_32_BIT)

return __builtin_ctzl(x);

-};

-inline int Utils::CountTrailingZeros(uint64_t x) {

+#elif defined(ARCH_IS_64_BIT)

return __builtin_ctzll(x);

+#else

+#error Architecture is not 32-bit or 64-bit.

+#endif

};

} // namespace dart

« no previous file with comments | « runtime/platform/utils.h ('k') | runtime/platform/utils_macos.h » ('j') | no next file with comments »