Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Issue 10805070: Flip HW video decode from being behind an "enable" flag to being behind a "disable" flag (Closed)

Created:
8 years, 5 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Pawel Osciak, sail, ananta
Visibility:
Public.

Description

Flip HW video decode from being behind an "enable" flag to being behind a "disable" flag with per-platform default settings (currently off for all but cros). This is in preparation for turning on HW decode by default one platform at a time. BUG=133827, 133828 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148452

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ami GONE FROM CHROMIUM
jam: please review posciak/sail/ananta: FYI John: am I hitting the crack pipe too hard? It ...
8 years, 5 months ago (2012-07-23 20:49:22 UTC) #1
jam
content lgtm with nit http://codereview.chromium.org/10805070/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/10805070/diff/1/content/renderer/render_view_impl.cc#newcode2370 content/renderer/render_view_impl.cc:2370: bool use_accelerated_video_decode; nit: it would ...
8 years, 5 months ago (2012-07-23 22:51:31 UTC) #2
Ami GONE FROM CHROMIUM
John: I was actually hoping you'd review the entire CL, not just content/. http://codereview.chromium.org/10805070/diff/1/content/renderer/render_view_impl.cc File ...
8 years, 5 months ago (2012-07-23 22:55:46 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10805070/diff/5001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://chromiumcodereview.appspot.com/10805070/diff/5001/content/renderer/render_view_impl.cc#newcode2371 content/renderer/render_view_impl.cc:2371: #if defined(OS_CHROMEOS) Turned on for cros/x86 (as well as ...
8 years, 5 months ago (2012-07-23 23:33:08 UTC) #4
Ami GONE FROM CHROMIUM
jam: ping? (hoping you'll lgtm for chrome/ as well)
8 years, 5 months ago (2012-07-25 05:03:31 UTC) #5
jam
lgtm
8 years, 5 months ago (2012-07-25 20:50:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10805070/13001
8 years, 5 months ago (2012-07-25 20:54:22 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 00:49:42 UTC) #8
Change committed as 148452

Powered by Google App Engine
This is Rietveld 408576698